Add agent-scoped skill configuration - #484
Open
artjen wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated behavior, is well-covered by targeted tests, and preserves backward-compatible defaults for existing users.
Pull request overview
This PR extends ucode skill add --mcp to support agent-scoped skill schema additions via a new --agents option, enabling one agent’s skills MCP scope to be updated without affecting other configured agents.
Changes:
- Add
--agentstoucode skill add --mcp, wiring it through CLI parsing/setup into MCP state updates. - Update skills MCP state so agent-scoped additions persist under per-client overrides while leaving the shared default scope intact.
- Add unit tests and README documentation covering agent-scoped behavior and download-mode validation.
File summaries
| File | Description |
|---|---|
src/ucode/mcp.py |
Extend add_skills_command to optionally write per-agent skill scope overrides and update only selected clients. |
src/ucode/cli.py |
Add --agents to skill add, validate it is MCP-only, and forward the resolved agent scope to add_skills_command. |
tests/test_mcp.py |
Add coverage for agent-scoped additions, preserving overrides during global additions, and persisting explicit intent. |
tests/test_cli.py |
Verify CLI agent scope setup/forwarding for --mcp and rejection of --agents in download mode. |
README.md |
Document agent-scoped MCP additions and clarify why download mode rejects --agents. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
artjen
force-pushed
the
skill-agent-add-command
branch
from
September 3, 2026 20:32
806106e to
e3ac2f3
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the described behavior, preserves existing scope semantics, and includes focused tests covering agent-scoped persistence and CLI validation paths.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Developers need to expose a skill schema to one coding agent without also exposing it to every other configured agent. This prevents unintended skill-tool crossover between agents.
What changed
This PR adds
--agentstoucode skill add --mcpand documents agent-scoped additions.How it works
--agents, locations are added to the shared default.--agents, locations are added only to each selected agent's durable additions.--agentsbecause its on-disk skill directories are shared.Builds on the client-aware state model in #468.
Testing
uv run pytest tests/test_skills_download.py tests/test_mcp.py tests/test_cli.py -q— 501 passeduv run ruff check .uv run ty check src/Tests cover global and targeted persistence, unaffected client URLs, durable overlapping additions, CLI forwarding, and download-mode validation.
Stack created with GitHub Stacks CLI • Give Feedback 💬