Pin nixpkgs by committing root flake.lock - #2
Merged
Merged
Conversation
Co-authored-by: dichhead <330471626+dichhead@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code for review comment 4052712068
Pin nixpkgs by committing root flake.lock
Sep 19, 2026
dasmatus
marked this pull request as ready for review
September 19, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The review comment flagged that
flake.nixreferencednixpkgs-unstablewithout a committed root lockfile, making first-timenix developnon-reproducible. This update addresses only that comment by adding the repository-rootflake.lock./flake.lockat repo root to pin thenixpkgsinput used by/flake.nix.flake.nix, build logic, or other repo files.{ "nodes": { "nixpkgs": { "locked": { "rev": "044bfe75bfe4c7bbe043dc17b5e42ea823b84a09" } } } }Why
Without a committed root
flake.lock, each environment resolves whatevernixpkgs-unstablepoints to at that moment, producing drift and dirty working trees. Committing the lockfile makes dev-shell resolution deterministic for contributors and CI.UI Changes
No UI changes.
Checklist