Skip to content

Encapsulating async call in AbstractDaprClient as a single method. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artursouza merged 1 commit into from
Dec 14, 2019
Merged

Encapsulating async call in AbstractDaprClient as a single method. #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 27 additions & 39 deletions sdk/src/main/java/io/dapr/actors/AbstractDaprClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
package io.dapr.actors;



import com.fasterxml.jackson.databind.ObjectMapper;

import okhttp3.*;
import reactor.core.publisher.Mono;
import reactor.core.scheduler.Schedulers;

import java.io.IOException;
import java.net.URL;
Expand Down Expand Up @@ -69,48 +68,37 @@ protected final Mono<Void> invokeAPIVoid(String method, String urlString, String
* @return Asynchronous text
*/
protected final Mono<String> invokeAPI(String method, String urlString, String json) {
return Mono.fromSupplier(() -> {
try {
return tryInvokeAPI(method, urlString, json);
} catch (IOException e) {
e.printStackTrace();
throw new RuntimeException(e);
}
});
}

/**
* Invokes an API synchronously and returns a text payload.
* @param method HTTP method.
* @param urlString url as String.
* @param json JSON payload or null.
* @return text
*/
protected final String tryInvokeAPI(String method, String urlString, String json) throws IOException {
String requestId = UUID.randomUUID().toString();
RequestBody body = json != null ? RequestBody.create(MEDIA_TYPE_APPLICATION_JSON, json) : REQUEST_BODY_EMPTY_JSON;

Request request = new Request.Builder()
.url(new URL(this.baseUrl + urlString))
.method(method, body)
.addHeader(Constants.HEADER_DAPR_REQUEST_ID, requestId)
.build();

// TODO: make this call async as well.
Response response = this.httpClient.newCall(request).execute();
if (!response.isSuccessful())
{
DaprError error = parseDaprError(response.body().string());
if ((error != null) && (error.getErrorCode() != null) && (error.getMessage() != null)) {
throw new DaprException(error);
}
RequestBody body = json != null ? RequestBody.create(json, MEDIA_TYPE_APPLICATION_JSON) : REQUEST_BODY_EMPTY_JSON;

throw new DaprException("UNKNOWN", String.format("Dapr's Actor API %s failed with return code %d %s", urlString, response.code()));
}
// use Mono blocking wrapper to be reactive
Mono<String> blockingWrapper = Mono.fromCallable(() -> {
Request request = new Request.Builder()
.url(new URL(this.baseUrl + urlString))
.method(method, body)
.addHeader(Constants.HEADER_DAPR_REQUEST_ID, requestId)
.build();


try(Response response = this.httpClient.newCall(request).execute())
{
if (!response.isSuccessful()) {
DaprError error = parseDaprError(response.body().string());
if ((error != null) && (error.getErrorCode() != null) && (error.getMessage() != null)) {
throw new DaprException(error);
}

return response.body().string();
throw new DaprException("UNKNOWN", String.format("Dapr's Actor API %s failed with return code %d %s", urlString, response.code()));
}

return response.body().string();
}
});

return blockingWrapper.subscribeOn(Schedulers.boundedElastic());
}


/**
* Tries to parse an error from Dapr response body.
* @param json Response body from Dapr.
Expand Down