Adding documentation for examples - #137
Closed
marcosreyes05 wants to merge 0 commit into
Closed
marcosreyes05 wants to merge 0 commit into
marcosreyes05 wants to merge 0 commit into
Conversation
artursouza
suggested changes
Jan 22, 2020
| * 2. cd to [repo-root]/examples | ||
| * 3. Run : | ||
| * dapr run --app-id inputbinding --app-port 3000 --port 3005 -- mvn exec:java -Dexec.mainClass=io.dapr.examples.bindings.http.InputBindingExample -Dexec.args="-p 3000" | ||
| * dapr run --app-id inputbinding --app-port 3000 --port 3005 -- mvn exec:java -D exec.mainClass=io.dapr.examples.bindings.http.InputBindingExample -D exec.args="-p 3000" |
Contributor
There was a problem hiding this comment.
Command does not work because class is still in the old package name.
| * 2. cd to [repo-root]/examples | ||
| * 3. Run the program: | ||
| * dapr run --app-id outputbinding --port 3006 -- mvn exec:java -Dexec.mainClass=io.dapr.examples.bindings.http.OutputBindingExample | ||
| * dapr run --app-id outputbinding --port 3006 -- mvn exec:java -D exec.mainClass=io.dapr.examples.bindings.http.OutputBindingExample |
Contributor
There was a problem hiding this comment.
Wrong package name here too.
| @@ -0,0 +1,130 @@ | |||
| # Dapr Bindings Sample | |||
|
|
|||
| In this sample, we'll create two java applications: An output binding application and an input binding application, using Dapr Java SDK. | |||
| # Dapr Bindings Sample | ||
|
|
||
| In this sample, we'll create two java applications: An output binding application and an input binding application, using Dapr Java SDK. | ||
| This sample includes two applications: |
Contributor
There was a problem hiding this comment.
Only enumerate the main classes. Controller should be described separately.
|
|
||
| ## Binding sample using the Java-SDK | ||
|
|
||
| This sample uses the capabilities provided in Dapr Java SDK for invoking bindings. Default implementation for binding event system is Kafka but others are also available. |
Contributor
There was a problem hiding this comment.
"for publishing bindings"
|
|
||
| ## Remote invocation using the Java-SDK | ||
|
|
||
| This sample uses the Client provided in Dapr Java SDK for exposing and invoking a remote method. |
Contributor
There was a problem hiding this comment.
For exposing the endpoint, it is not using the SDK anymore. We are using Springboot but not the SDK directly.
Contributor
There was a problem hiding this comment.
For invoking we still use the SDK.
| // If port string is not valid, it will throw an exception. | ||
| int port = Integer.parseInt(cmd.getOptionValue("port")); | ||
|
|
||
| DaprApplication.start(port); |
Contributor
There was a problem hiding this comment.
Explain what this command does and what the DaprApplication class does.
| */ | ||
|
|
||
| package io.dapr.examples.pubsub.http; | ||
| package io.dapr.examples.pubsub; |
Contributor
There was a problem hiding this comment.
This example will become http specific again.
|
|
||
| Messages have been published in the topic. | ||
|
|
||
| ### Running the subscriber |
Contributor
There was a problem hiding this comment.
I would imagine that the subscriber would run first.
|
|
||
| ### Running the subscriber | ||
|
|
||
| The other component is the subscriber. It will subscribe to the same topic used by the publisher and read the messages previously published. The Subscriber uses the Spring Boot´s DaprApplication class for initializing the `SubscriberController`. In `Subscriber.java` file, you will find the `Subscriber` class and the `main` method. See the code snippet below: |
Contributor
There was a problem hiding this comment.
Because it refers to SpringBoot now, it is http-specific again.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding documentation for examples
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[37] #[36] #[87]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: