Define dnpublic_network in the docker-compose.yml #66

Activity

1. pablomendezroyo

   assigned

   3alpha

   and

   pablomendezroyo

   on May 17, 2022
2. dapplion commented on May 18, 2022

   

   dapplion

   on May 18, 2022

   Collaborator

   More actions

   @pablomendezroyo can you justify why

   This is not the best approach and should be defined in the https package docker-compose.yml.
3. pablomendezroyo commented on May 18, 2022

   

   pablomendezroyo

   on May 18, 2022

   ContributorAuthor

   More actions

   The best way of working with Docker is to use the default built-in features to avoid human errors and automate as much as possible. In this case, the dnpublic_network must exist only if the HTTPS container is present. This can easily be achieved by defining it as a docker internal network in the docker-compose.yml of the HTTPS package.

   The docker-compose down will attempt to remove internal networks (must see what happens if there are still running docker containers on it).

   Furthermore, the SDK should have whitelisted which docker networks are allowed (right now should be only dncore and dnpublic
4. dapplion commented on May 19, 2022

   

   dapplion

   on May 19, 2022

   Collaborator

   More actions

   Could you do some tests to check if that would work? What happens if you uninstall the https and there's still some other package on the public network?
5. 3alpha commented on May 19, 2022

   

   3alpha

   on May 19, 2022

   Last edited by 3alpha

   Member

   More actions

   This is what DAppManager does when HTTPS package is installed. It must be done that way because it is only way to ensure that dnpublic_network network exists on host since it is declared as external in compose. Starting compose with external network that doesn't exists fails.
6. pablomendezroyo commented on May 19, 2022

   

   pablomendezroyo

   on May 19, 2022

   ContributorAuthor

   More actions

   I think the best approach would be:

   • Declare docker internal network dnpublic_network in https compose
   • In SDK and dappmanager allow just two docker networks: dnpublic and dncore
   • When installing https package it will create the dnpublic docker network in dappnode environemt.
   • When removing https package there will be an warning like error docker network in used by other containers. The dnpublic network does not makes sense without the https container, then it should be remove the docker networ dnpublic from all the containers