Repository navigation
Fix broken images in VPN page - #150
Conversation
There was a problem hiding this comment.
this error you show isn't showing for me so i don't see a reason to change the paths right now when really nothing seems to be wrong.
EDIT.
Please create or find an open issue before submitting a PR for any of our repos so we have everything fully documented, with all context. It can be done here https://github.com/dappnode/DAppNodeDocs/issues.
I'll go ahead and create an issue and link it. But there are just a few other images that aren't rendering likely for the same reason throughout the docs, so while I can likely merge this shortly; the issue i create about improperly rendered images will remain open. We would absolutely love if you want to help fix or at least look into any of those other docs image issues.
Ahah i love it - hello? - super welcoming repo here 😳 "I don't see the error" 😅😅😅 Are you making software just for you? Do you really think I spent 30min to send this PR for fun? Next time I'll just open the issue and let you deal with it. Believe it or not, there is an issue with these images. My help stops here. |
|
https://docs.dappnode.io/user-guide/ui/recommended-set-ups/add-vpn-devices/ https://docs.dappnode.io/user-guide/img/add_wireguard_device_3.png One half of the page loads images from |
|
Wow, I apologize, seems you misunderstood me. I reviewed the current docs site and the deployed Netlify link with your fix and found them to be completely identical on both Brave and Chrome browsers, which are the most used browsers by our community. Without literally any context of the issue aside from just a partial screen grab there wasn't much to go on to try to reproduce it. I don't know why my review didn't include a comment asking you to make an issue to link to or at least ask for more context since 2 attempts to reproduce the issue, failed for me during my review thus request for changes, but it's totally on me for not adding that comment, not sure if i just blanked and forgot as I was doing something else at the same time, or if something bugged out, but anyways I apologize we got off on the wrong foot, once again Welcome to the community! I'll edit my previous comment with what i failed to include and will make an issue for this if you would like, since it's more widespread than your fixes from whatI've seen so far but could also be a totally different issue. |
|
All good thanks, I'll open an issue ;) |








EDIT: created issue: #151
Before PR:
After PR:
If images are in the static folder, you can simply use
/img/........instead of../../../img-> this will make it more bulletproof if you change pages folders