Skip to content

fix(installer): reserve core IPs outside Docker automatic allocation - #739

Open
sembrestels wants to merge 1 commit into
dappnode:masterfrom
sembrestels:fix/reserve-core-docker-addresses
Open

sembrestels wants to merge 1 commit into
dappnode:masterfrom
sembrestels:fix/reserve-core-docker-addresses

Conversation

@sembrestels

Copy link
Copy Markdown

Create dncore_network with subnet 172.33.0.0/16, gateway 172.33.0.1 and dynamic allocation range 172.33.128.0/17. This keeps DNS 172.33.1.2 and Dappmanager 172.33.1.7 outside automatic allocation and matches Dappmanager's companion address-allocation policy.

Existing networks are retained. Legacy allocation settings produce an actionable migration notice after upgrading Dappmanager; the installer does not silently replace an active bridge. Network-creation failures propagate instead of being ignored.

Validation:

  • bash -n scripts/dappnode_install.sh passed.
  • bash test/network_pool.sh passed: fresh pool creation, an existing compatible pool, a non-disruptive legacy-network notice, and propagation of creation failures.
  • Added the regression test to the installer workflow.
  • The matching Dappmanager policy was applied and tested on the same host through three actual Docker daemon restarts. Networking and validator checks passed, followed by a successful attestation. The private-network pool is created by Dappmanager.

Pair with Dappmanager branch fix/separate-static-docker-addresses for the existing-installation migration and recovery tooling. Its operational capacity checks and external-service validation limitations are described in the companion PR text and validation report.

@sembrestels
sembrestels requested a review from a team as a code owner October 31, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant