Skip to content

Allow to create relesaes with extra non-core packages #493

Open

Description

@pablomendezroyo

In order to accomplish partnerships with different projects it may be necessary to create dappnode releases with packages preinstalled or the UIX onboarding instructions to install it.

  • Add an env to the docker-compose.yml file named EXTRA_PKGS. This env will be a string comma separated of dnp's names + version to be installed. There must be a regex to ensure there is versioning and proper naming.
  • The installer will check if the env is defined, if so it will create a file named extra-pkgs.json at the path /usr/src/dappnode/DNCORE with the following format:
[
   {
    dnpName: string,
    version: string,
    title?: string,
    description?: string
  },
  ...
]
  • Implement in the gha release a new optional input that will be a string comma separated of DNP's names. If introduced, then edit the docker-compose env with the value and generate an extra release asset named DAppNode-v0.2.57-extra-pkgs-debian-bullseye-amd64-unattended.iso.

┆Issue is synchronized with this Basecamp todo by Unito

Activity

  1. pablomendezroyo commented on Mar 1, 2023

    @pablomendezroyo
    ContributorAuthor

    The GHA env EXTRA_PKGS must have the format:

    dnpName1:x.y.z,dnpName2:x.y.z
    
  2. dsimog01 commented on Mar 1, 2023

    @dsimog01
    Contributor

    If we need to avoid having connection to an ETH node at the moment of the installation, @pablomendezroyo and I have discussed that it could make sense to include the IPFS hash instead of the dnpName. However, if the user needs to be redirected to the installer, the package will appear as not signed, right?

  3. dsimog01 commented on Mar 1, 2023

    @dsimog01
    Contributor

    Also, we need to be sure that the package install function of the dappmanager allows IPFS hashes, not only dnp names, as arguments

  4. dsimog01 commented on Mar 1, 2023

    @dsimog01
    Contributor

    Moreover, we could add a field "needsUserInput: boolean" that tells the dappmanager whether the user must include any desired configuration to the package before installation. If this value is false, the installation can be performed in an asynchronous way, so that the onboarding process is more fluent. Do we have to add an "install" button that will allow the user to avoid installing that package? Or is this going to be mandatory? Also, if needsUserInput==true, the user could be redirected to the installer wizard

  5. added
    P1Has to be done but not urgent
    on May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1Has to be done but not urgentinstallerThis issue is related to the installer

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions