Repository navigation
DAOS-19636 object: fix client layout refresh races - #19248
Merged
Merged
Conversation
|
Ticket title is 'Object client may use inconsistent layout data during replica retry' |
Layout refresh during rebuild or reintegration can invalidate physical shard indices between selection, target preparation, and RPC dispatch. Protect layout accesses and retain consistent request shard identities. - Revalidate opened shards under cob_lock and snapshot endpoints, target IDs, logical shard IDs, EC indices, and rebuild flags consistently. - Make EC fetch, degraded reads, parity, and enumeration selection version-aware; propagate DER_STALE instead of using mismatched layouts. - Reject stale target lists before fanout via normal task completion. - Preserve saved EC indices for checksum and enumeration processing. - Identify sub-anchors by logical shard ID and use fixed class widths for group-anchor arithmetic across extended layout changes. - Skip success-output processing on failed attempts and validate key-to-anchor group boundaries against the requested map version. - Use a stable stride for CPD classification and resolve leaders from classified entries; protect forced-leader lookup and timestamp updates. - Reselect replicas after map changes, establish a new retry-cycle start, and preserve redundancy errors when no eligible replica remains. Signed-off-by: Liang Zhen <gnailzenh@gmail.com> Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@hpe.com>
gnailzenh
force-pushed
the
liang/b_layout_race
branch
from
October 12, 2026 12:39
f0bc3d4 to
db21396
Compare
Collaborator
|
Test stage Functional Hardware Medium Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19248/2/execution/node/1987/log |
wangshilong
approved these changes
Oct 14, 2026
Nasf-Fan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout refresh during rebuild or reintegration can invalidate physical shard indices between selection, target preparation, and RPC dispatch. Protect layout accesses and retain consistent request shard identities.
Steps for the author:
After all prior steps are complete: