Skip to content

DAOS-19371 vos: object alloc & pin - #19232

Merged
NiuYawei merged 2 commits into
feature/mdonssd_p2_improvefrom
niu/mdonssd_p2_improve/DAOS-19371-alloc
Oct 14, 2026
Merged

DAOS-19371 vos: object alloc & pin#19232
NiuYawei merged 2 commits into
feature/mdonssd_p2_improvefrom
niu/mdonssd_p2_improve/DAOS-19371-alloc

Conversation

@NiuYawei

@NiuYawei NiuYawei commented Oct 10, 2026

Copy link
Copy Markdown
Contributor
  • Leverage new allocator interface to pass in current object bucket IDs and handle spillover.
  • Persist & free object bucket IDs properly.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@NiuYawei
NiuYawei requested review from a team as code owners October 10, 2026 03:44
@NiuYawei
NiuYawei requested review from sherintg and wangshilong and removed request for a team and sherintg October 10, 2026 03:44
@github-actions

github-actions Bot commented Oct 10, 2026

Copy link
Copy Markdown

Ticket title is 'Refactor VOS to support multiple E buckets per object'
Status is 'In Progress'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-19371

@NiuYawei
NiuYawei requested a review from sherintg October 10, 2026 03:45
@daosbuild3

daosbuild3 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-19232/1/testReport/

@daosbuild3

daosbuild3 commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19232/1/execution/node/1963/log

@NiuYawei
DAOS-19371 vos: object alloc & pin
6ad9b51 
- Leverage new allocator interface to pass in current object bucket IDs
  and handle spillover.
- Persist & free object bucket IDs properly.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei
NiuYawei force-pushed the niu/mdonssd_p2_improve/DAOS-19371-alloc branch from 7d4930f to 6ad9b51 Compare October 12, 2026 04:10
sherintg
sherintg reviewed Oct 12, 2026
View reviewed changes
Comment thread src/vos/vos_obj_cache.c Outdated
{
int i;

D_ASSERT(node->bn_bkt_cnt > 0 && node->bn_bkt_cnt < VOS_OBJ_BKT_NODE_CAP);

@sherintg sherintg Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be node->bn_bkt_cnt <= VOS_OBJ_BKT_NODE_CAP right?

@NiuYawei NiuYawei Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed.

Comment thread src/vos/vos_obj_cache.c
Comment thread src/vos/vos_internal.h Outdated
for (node = obj->obj_bkt_nodes; node != NULL; node = node->bn_next) {
for (i = 0; i < node->bn_bkt_cnt && cnt < VOS_OBJ_BKTS_MAX; i++) {
if (vos_bkt_id_is_shared(node->bn_bkt_ids[i])) {
D_ASSERT(cnt < VOS_OBJ_BKTS_MAX);

@sherintg sherintg Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant assert?

@NiuYawei NiuYawei Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed.

NiuYawei
NiuYawei commented Oct 12, 2026
View reviewed changes

@NiuYawei NiuYawei left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review.

@NiuYawei
DAOS-19371 vos: address review comments
f0c703a 
Address review comments from Sherin.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei
NiuYawei requested a review from sherintg October 12, 2026 08:11
@daosbuild3

daosbuild3 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19232/2/execution/node/1757/log

@daosbuild3

daosbuild3 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Cluster Box Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19232/2/execution/node/1772/log

@daosbuild3

daosbuild3 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-19232/2/execution/node/1791/log

@NiuYawei
NiuYawei merged commit d50df0c into feature/mdonssd_p2_improve Oct 14, 2026
39 checks passed
@NiuYawei
NiuYawei deleted the niu/mdonssd_p2_improve/DAOS-19371-alloc branch October 14, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sherintg sherintg sherintg approved these changes
@wangshilong wangshilong Awaiting requested review from wangshilong

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NiuYawei @daosbuild3 @sherintg