Repository navigation
DAOS-18681 rebuild: fix potential memory leaks in error paths - #17899
Merged
Merged
Conversation
Fix potential memory leaks in error cases in rebuild and IV path. Also Fixed a memmory allocation check typo to avoid potential crash Removed stale comments Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
|
Ticket title is 'Fix potential memory Leaks ' |
github-actions
Bot
added
the
priority
This patch fixes several resource-handling bugs that could lead to memory leaks or crashes(all catched by AI): 1.Avoid leaking memory allocated in tse_task_cb() when tse_task_reinit_with_delay() fails by introducing a helper to clean up on failure. 2. Ensure sub_anchors_free() is called on error paths for enumeration and key2anchor case. 3. Invoke dc_tx_local_close() on error paths to properly close local transactions. 4. Make drpc_call() return an error when allocation fails to avoid potential NULL dereference and segfault. Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
Nasf-Fan
approved these changes
Apr 8, 2026
gnailzenh
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix potential memory leaks in error cases in rebuild and IV path. Also Fixed a memmory allocation check typo to avoid potential crash
Removed stale comments
Steps for the author:
After all prior steps are complete: