Skip to content

DAOS-18323 ddb: Incorrect parsing of vos path with DDB - #17340

Merged
gnailzenh merged 61 commits into
masterfrom
ckochhof/fix/master/daos-18323
Apr 1, 2026
Merged

DAOS-18323 ddb: Incorrect parsing of vos path with DDB#17340
gnailzenh merged 61 commits into
masterfrom
ckochhof/fix/master/daos-18323

Conversation

@knard38

@knard38 knard38 commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix ddb vos file path parsing.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@knard38 knard38 self-assigned this Jan 5, 2026
@github-actions

github-actions Bot commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Ticket title is 'Incorrect parsing of vos path with DDB'
Status is 'In Progress'
Labels: 'scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18323

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch 2 times, most recently from 5e2dff4 to 465cf2a Compare January 5, 2026 09:27
@knard38
knard38 changed the base branch from master to ckochhof/fix/master/daos-18292 January 5, 2026 10:33
@knard38 knard38 changed the title Ckochhof/fix/master/daos 18323 DAOS-18323 ddb: Incorrect parsing of vos path with DDB Jan 5, 2026
@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from caf8936 to 72a9f0c Compare January 5, 2026 11:06
@daosbuild3

daosbuild3 commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17340/4/testReport/

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from 465cf2a to 8b02e09 Compare January 5, 2026 13:40
@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18292 branch 2 times, most recently from 795df75 to 0187ab0 Compare January 8, 2026 08:43
@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from 0187ab0 to 0f34795 Compare January 29, 2026 08:46
@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch 2 times, most recently from 08b5a70 to f23c95c Compare January 29, 2026 08:59
@daosbuild3

daosbuild3 commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17340/7/testReport/

@daosbuild3

daosbuild3 commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17340/7/testReport/

@daosbuild3

daosbuild3 commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17340/7/testReport/

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from f23c95c to c013fe7 Compare January 29, 2026 13:32
@daosbuild3

daosbuild3 commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/7/execution/node/1088/log

@daosbuild3

daosbuild3 commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/8/execution/node/310/log

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18292 branch from 0f34795 to 981d4b8 Compare February 6, 2026 14:09
@knard38
knard38 changed the base branch from ckochhof/fix/master/daos-18292 to master February 6, 2026 15:40
@daosbuild3

daosbuild3 commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/9/execution/node/339/log

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from c013fe7 to 112b5c0 Compare February 9, 2026 08:55
@daosbuild3

daosbuild3 commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/10/execution/node/292/log

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from 112b5c0 to 77eb90a Compare February 9, 2026 09:24
@daosbuild3

daosbuild3 commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/11/execution/node/307/log

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from 77eb90a to 4d76448 Compare February 9, 2026 10:28
@daosbuild3

daosbuild3 commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

Test stage Build on EL 9.6 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/12/execution/node/307/log

@knard38
knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from 4d76448 to f8abb2e Compare February 9, 2026 13:24
kanard38 added 2 commits March 24, 2026 07:43
@kanard38 @knard38
Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…
c651153 
…/daos-18323

Features: recovery
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
ff4eb90 
Remove useless comments.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
janekmi
janekmi requested changes Mar 24, 2026
View reviewed changes
Comment thread src/utils/ddb/ddb_parse.c Outdated
Comment thread src/utils/ddb/ddb_parse.c Outdated
Comment thread src/utils/ddb/ddb_parse.c Outdated
Comment thread src/utils/ddb/ddb_parse.c Outdated
Comment thread src/utils/ddb/ddb_parse.c
Comment thread src/utils/ddb/ddb_parse.c Outdated
Comment thread src/utils/ddb/tests/ddb_test_driver.c Outdated
Comment thread src/utils/ddb/tests/ddb_ut.c Outdated
Comment thread src/utils/ddb/tests/ddb_test_driver.c Outdated
Comment thread src/utils/ddb/tests/ddb_parse_tests.c Outdated
kanard38 added 8 commits March 24, 2026 13:24
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
9a313a8 
Fix reviewrs comments:
- Fix comment parse_vos_file_parts -> init_regex_vos_file_parts

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
0f0912d 
Fix reviewrs comments:
- Use specific error code DER_EXCEEDS_PATH_LEN

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
a344926 
Fix reviewrs comments:
- Convert to assert

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
c39ee69 
Fix reviewrs comments:
- Use DER_SUCCESS

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
14a1e9d 
Fix reviewrs comments:
- Improve cmocka filtering unsupported message

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
a865217 
Fix reviewrs comments:
- Check and fix command options parse

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
9c7840a 
Fix reviewrs comments:
- Improve invalid VOS path message clarity

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…
bab70fb 
…/daos-18323

Features: recovery
@knard38
knard38 requested a review from janekmi March 26, 2026 07:28
janekmi
janekmi requested changes Mar 30, 2026
View reviewed changes
Comment thread src/utils/ddb/tests/ddb_ut.c Outdated
Comment thread src/utils/ddb/tests/ddb_test_driver.c Outdated
Comment thread src/utils/ddb/ddb_parse.c
Comment thread src/utils/ddb/ddb_parse.c
Comment thread src/utils/ddb/ddb_parse.c Outdated
kanard38 added 3 commits March 30, 2026 12:12
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
29174ef 
Fix reviewrs comments:
- Fix invalid warning message

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
b782bcb 
Fix reviewrs comments:
- Use one line message

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@kanard38 @knard38
DAOS-18323 ddb: Incorrect parsing of vos path with DDB
f7d759c 
Fix reviewrs comments:
- Test errno against ERANGE

Features: recovery
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
@daosbuild3

daosbuild3 commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/39/execution/node/1039/log

@knard38
knard38 requested a review from janekmi March 30, 2026 13:12
@janekmi janekmi mentioned this pull request Mar 31, 2026
Merged
6 tasks done
@daltonbohning daltonbohning added the approved-to-merge PR has received release branch merge approval label Mar 31, 2026
@daosbuild3

daosbuild3 commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/42/execution/node/1299/log

@Nasf-Fan

Nasf-Fan commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/42/execution/node/1299/log

Re-triggered Hardware Test as Liang suggested for the trouble during hardware preparation.

@knard38

knard38 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17340/42/execution/node/1299/log

Re-triggered Hardware Test as Liang suggested for the trouble during hardware preparation.

Thanks to have restart the functional test... not so easy these days to have run of the CI without false positives :-(

@gnailzenh
gnailzenh merged commit 398aa06 into master Apr 1, 2026
42 checks passed
@gnailzenh
gnailzenh deleted the ckochhof/fix/master/daos-18323 branch April 1, 2026 12:31
@knard38

knard38 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @gnailzenh for the merge, I was going to ask the gatekeeper :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekmi janekmi janekmi approved these changes
@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes
@wangshilong wangshilong Awaiting requested review from wangshilong

Assignees

@knard38 knard38

Labels

approved-to-merge PR has received release branch merge approval CR Catastrophic Recovery Feature priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@knard38 @daosbuild3 @Nasf-Fan @janekmi @wangshilong @gnailzenh @daltonbohning @kanard38