Repository navigation
fix(pulumi): smtp-relay の所有者を apply のサービスプリンシパルの ID で直に書く - #537
Merged
Merged
Conversation
getClientConfig は PR の preview(読み取り用の資格情報)では別の ID を返し、毎回 owners の差分が出ていた。 talos/README.md に cert-manager-startupapicheck の Job も消して流し直す、を足す。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NN4TmSXHrMP8dkTbtkjfz1
|
Claude finished @5ym's task in 11s —— View job レビュー結果重大な問題は見つかりませんでした。 pulumi/entra-smtp.ts
talos/README.md
テストについては、インフラのコードなので preview の結果で確かめる運用で十分です。 |
🍹
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getClientConfigOutput()は PR の preview(読み取り用の資格情報)では別のオブジェクト ID を返すので、PR のたびに smtp-relay の Application / ServicePrincipal に~ownersの差分が出ていた(main の up は変更なし)。apply のサービスプリンシパルのオブジェクト ID を直に書く。preview が 0 to update になれば ID が合っている。ついでに talos/README.md に、
cert-manager-startupapicheckの Job がfield is immutableで止まったら消して流し直す、を足す(2026-10-24 に踏んだ)。🤖 Generated with Claude Code
https://claude.ai/code/session_01NN4TmSXHrMP8dkTbtkjfz1