Repository navigation
feat: add opt-in PostgreSQL BYTEA preservation - #223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL map-backed reads currently turn
[]byteresults into strings, which corrupts BYTEA containing invalid UTF-8 when an API serializes the result. This adds opt-inDbOptions.PreserveBinaryValues; it retains copied byte slices only for PostgreSQL columns whose driver metadata reportsBYTEA. The zero value and all other column types keep their existing behavior. Map-backedGet/GetMultiuse the same path; recordset reads already preserve byte slices.Validation:
go test ./... -count=1,go vet ./..., andgolangci-lint run ./...pass throughwb run. Tests cover binary NUL/invalid UTF-8, empty versus NULL values, text/default compatibility, recordset reads, and owned copies.