chore: 🔀 merge upstream nightly v0.0.43-nightly.20260924.2187 - #6
Closed
chamaquita-d3[bot] wants to merge 12 commits into
Closed
chamaquita-d3[bot] wants to merge 12 commits into
chamaquita-d3[bot] wants to merge 12 commits into
Conversation
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
…otgg#11580) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…ctory-test/base Upstream switched the effort dropdown's icon from GaugeIcon to BrainIcon in the same three lines where the fork had switched it to ActivityIcon. Kept the fork's ActivityIcon and took upstream's lockfile, reconciled with pnpm install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
DiegoJohnsonL
deleted the
chamaquita/upstream-v0.0.43-nightly.20260924.2187
branch
September 24, 2026 07:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging upstream nightly v0.0.43-nightly.20260924.2187 into
factory-test/basestopped on one conflicted file, so no custom build could be published. This merges the tag with--no-ff(keeping it an ancestor of the branch) and resolves the conflict.Upstream's #13309 swapped the effort dropdown's
GaugeIconforBrainIconin exactly the three lines where the fork's aae14db had swapped it forActivityIcon. Same question, different answers: the fork's icon choice is a deliberate customization, so it wins. Nothing else in the file was touched, and every other upstream change merged cleanly.Conflict resolution
apps/web/src/components/chat/TraitsPicker.tsx:19import { ActivityIcon, ZapIcon }import { BrainIcon, ZapIcon }ActivityIcon)GaugeIcon; the fork's icon is its own customization, so the import follows its usages.apps/web/src/components/chat/TraitsPicker.tsx:652<ComposerControlIcon icon={ActivityIcon} …>(compact trigger)<ComposerControlIcon icon={BrainIcon} …>ActivityIcon)apps/web/src/components/chat/TraitsPicker.tsx:671<ComposerControlIcon icon={ActivityIcon} …>(expanded trigger)<ComposerControlIcon icon={BrainIcon} …>ActivityIcon)pnpm-lock.yamlwas not hand-merged: upstream's lockfile was taken wholesale and reconciled with the merged manifests bypnpm install, which re-added the fork's 42 lines of extra dependencies.git grep -nE '^(<<<<<<<|>>>>>>>) 'finds nothing, andgit merge-base --is-ancestor v0.0.43-nightly.20260924.2187 HEADsucceeds.Checks
pnpm install --frozen-lockfilepnpm run typecheck--concurrency-limit 1; the default limit of 2 gets the server'stscOOM-killed with exit 137 on this 2-core sandbox)pnpm exec vp fmt --checkpnpm exec vp lint apps/web/src/components/chat/TraitsPicker.tsxpnpm exec vp run --filter t3 testpnpm exec vp run --parallel --concurrency-limit 2 --filter '!t3' --filter '!@t3tools/monorepo' testpnpm run build:desktopThe 101 server failures are confined to
src/git/GitManager.test.tsandsrc/vcs/GitVcsDriverCore.test.ts, and every one is aGitCommandErrorfrom agitsubprocess in a/tmpscratch repo. Checking outfactory-test/basein the same sandbox and running those two files reproduces exactly 101 failures / 111 passed, so they are a property of this sandbox's git, not of the merge — which touches only a web icon import and the lockfile and cannot reach the VCS driver.Fixes #5
🤖 Generated with Claude Code