Repository navigation
Keep the port in ETH node URLs - #1492
Merged
Merged
Conversation
The node form moves a port typed into the host field over to the port field and strips it from the host. ETH connects to the host URL as is and never reads the port field, so a node like http://127.0.0.1:8545 ended up being contacted on port 80. Leave the URL alone for ETH and only fill in the port field.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1492 +/- ##
===========================================
- Coverage 10.74% 10.74% -0.01%
===========================================
Files 1132 1132
Lines 113993 113994 +1
===========================================
Hits 12254 12254
- Misses 101739 101740 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The add/edit node form moves a port typed into the host field over to the port field and strips it from the host. That is right for every coin that builds its connection from host plus port, but Ethereum connects to the host URL as is and never reads the port field. A node entered as
http://127.0.0.1:8545was saved ashttp://127.0.0.1with port 8545 in the separate field, and the wallet then contacted port 80.For Ethereum the URL is now left alone and only the port field is filled in from it. Other coins are unchanged.
Notes
if (widget.coin is! Ethereum)around the existing URL rewrite.Checks
dart format --set-exit-if-changedclean on the changed fileflutter test: all passed on the rebased tip