Skip to content

Keep the port in ETH node URLs - #1492

Merged
julian-CStack merged 1 commit into
stagingfrom
pr1479/eth-url-port
Nov 2, 2026
Merged

julian-CStack merged 1 commit into
stagingfrom
pr1479/eth-url-port

Conversation

@sneurlax

@sneurlax sneurlax commented Nov 1, 2026

Copy link
Copy Markdown
Member

Summary

The add/edit node form moves a port typed into the host field over to the port field and strips it from the host. That is right for every coin that builds its connection from host plus port, but Ethereum connects to the host URL as is and never reads the port field. A node entered as http://127.0.0.1:8545 was saved as http://127.0.0.1 with port 8545 in the separate field, and the wallet then contacted port 80.

For Ethereum the URL is now left alone and only the port field is filled in from it. Other coins are unchanged.

Notes

  • One file, one if (widget.coin is! Ethereum) around the existing URL rewrite.
  • Independent of Add Tor support for Ethereum, fix clearnet image loads in Tor mode #1479. It applies cleanly on top of that PR as well.
  • No test covers the node form's text controllers today, so there is no new test. To check by hand: add an ETH node with a port in the URL, save, reopen, and the host field still shows the port.

Checks

  • dart format --set-exit-if-changed clean on the changed file
  • flutter test: all passed on the rebased tip

The node form moves a port typed into the host field over to the port
field and strips it from the host. ETH connects to the host URL as is
and never reads the port field, so a node like http://127.0.0.1:8545
ended up being contacted on port 80. Leave the URL alone for ETH and
only fill in the port field.
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.74%. Comparing base (ad1efd5) to head (2dd6a16).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...gs_view/manage_nodes_views/add_edit_node_view.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1492      +/-   ##
===========================================
- Coverage    10.74%   10.74%   -0.01%     
===========================================
  Files         1132     1132              
  Lines       113993   113994       +1     
===========================================
  Hits         12254    12254              
- Misses      101739   101740       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julian-CStack
julian-CStack merged commit db805c0 into staging Nov 2, 2026
3 of 4 checks passed
@julian-CStack
julian-CStack deleted the pr1479/eth-url-port branch November 2, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants