Repository navigation
Conversation
Member
Author
|
This whole PR is being superceded by the alternative slate of native-assets migrations which make these changes unnecessary. gg |
Collaborator
|
a small portion of this may still be required. Will reopen just for reference |
Keep released device dependencies by default; scope legacy simulator review pins to explicit iOS configuration. Validate Wallet/Duo configuration across platforms and document native-assets and ABI limits.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1433 +/- ##
========================================
Coverage 13.92% 13.92%
========================================
Files 1139 1139
Lines 114707 114707
========================================
Hits 15976 15976
Misses 98731 98731 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds experimental, opt-in Apple Silicon iOS simulator configuration while keeping normal device builds on staging's released dependencies.
Set
STACK_IOS_SIMULATOR=1when configuring theiostarget. Stack Wallet enables the review-pinned Monero and Wownero simulator packages; Stack Duo enables only Monero. Other platforms and ordinary iOS configuration keep their released dependencies and the staging lockfile. The CocoaPods arm64 simulator architecture selection remains.The earlier submodule/MWEB overrides and build instructions were partly superseded by Flutter Native Assets. Documentation now describes the current setup, opt-in usage, and its limits.
The six original prerequisite PRs are all closed without merging:
Not release-ready: these simulator pins predate the current device-library ABI. The Monero pin lacks
MONERO_Wallet_serializeCacheToJson, exported by the current device package. Stack does not currently call that symbol, but the mismatch still requires refreshed simulator libraries and macOS linking/wallet smoke tests. Linux configuration checks do not establish a working iOS simulator build.Validation: 12 regression cases invoke the actual Wallet/Duo configure scripts and template/interface processors across default, disabled, enabled, and non-iOS scenarios. Scoped Dart analysis reports no issues; Bash syntax and Ruby Podfile syntax pass.
pubspec.lockis identical to staging, obsolete crypto-plugin gitlinks remain removed, andgit diff --checkpasses. Both remotes contain the same refreshed commit.