Repository navigation
Conversation
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
these shouldn't exist/happen, but do/can
previously if it had a newline at the beginning it would choke
previously if it had a newline at the beginning it would choke
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
`git diff --name-only --diff-filter=d origin/staging | grep '\.dart$' | xargs -r dart format && git diff --name-only --diff-filter=d | grep '\.dart$' | xargs -r git commit -m "chore: dart format"`
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1384 +/- ##
===========================================
- Coverage 4.84% 4.83% -0.01%
===========================================
Files 1092 1093 +1
Lines 109141 109422 +281
===========================================
+ Hits 5283 5289 +6
- Misses 103858 104133 +275 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
not needed |
Serializes open, node updates, native replacement and shutdown on a single mutex, and rejects queued work once shutdown has begun. The Tor transition gate parks a node update while Tor is bootstrapping and abandons it as soon as the operation is superseded.
Every LibMonero/Wownero/Salvium instance subscribed to the Tor status and preference events from its constructor, so toggling Tor ran updateNode() on the dozens of wallets Wallets.load() constructs but never opens. With a Tor-only or clearnet-only node the TOR/clearnet mismatch escaped the async listener as an unhandled exception. Listeners are now attached in open() and detached on exit() or a failed open, and the native lifecycle runs through CryptonoteWalletLifecycle so concurrent open/exit calls cannot load or tear down the native wallet twice. Because an exited wallet no longer follows node or Tor changes, open() re-runs the node update whenever the native daemon session was torn down; otherwise a reopened wallet resumes syncing over its stale clearnet session. Also corrects the inverted null guard in recoverViewOnly().
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
previously if it had a newline at the beginning it would choke
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
…20261110/pr-1261 # Conflicts: # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/wallet_keys_desktop_popup.dart # lib/services/wallets.dart # lib/utilities/address_utils.dart # test/address_utils_test.dart
…20261110/pr-1278 # Conflicts: # lib/utilities/address_utils.dart
# Conflicts: # lib/pages/add_wallet_views/restore_wallet_view/restore_options_view/restore_options_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/delete_wallet_warning_view.dart # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_attention_delete_wallet.dart # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/unlock_wallet_keys_desktop.dart # lib/utilities/address_utils.dart
…20261110/pr-1261 # Conflicts: # lib/pages/add_wallet_views/restore_wallet_view/restore_options_view/restore_options_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_backup_views/wallet_backup_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/delete_wallet_recovery_phrase_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/delete_wallet_warning_view.dart # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart # lib/utilities/address_utils.dart # lib/wallets/wallet/impl/monero_wallet.dart # lib/wallets/wallet/intermediate/lib_monero_wallet.dart # lib/wl_gen/interfaces/cs_monero_interface.dart # test/address_utils_test.dart
…20261110/pr-1278 # Conflicts: # lib/pages/add_wallet_views/restore_wallet_view/restore_options_view/restore_options_view.dart
|
Updated this shared restore-date/height branch to staging Validation: 73 focused URI, payment parsing, restore UI, recovery-material and secure-storage tests passed. Targeted Dart analysis reported no errors, with existing informational lints. Native chain restore, device behavior, and date-to-height accuracy were not exercised end to end. PRs #1278 and #1384 now point to this same reviewed commit. |
|
Follow-up |
No description provided.