Skip to content

feat: show/hide balances toggle - #1379

Draft
sneurlax wants to merge 7 commits into
stagingfrom
feat/168-hide-balances
Draft

sneurlax wants to merge 7 commits into
stagingfrom
feat/168-hide-balances

Conversation

@sneurlax

Copy link
Copy Markdown
Member

closes #168

@codecov

codecov Bot commented May 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 19.31540% with 660 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.04%. Comparing base (9ce80be) to head (2755275).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../pages/wallets_view/sub_widgets/favorite_card.dart 0.00% 65 Missing ⚠️
...ages/token_view/sub_widgets/token_summary_sol.dart 0.00% 58 Missing ⚠️
..._menu/appearance_settings/appearance_settings.dart 1.92% 51 Missing ⚠️
...ib/pages/token_view/sub_widgets/token_summary.dart 0.00% 48 Missing ⚠️
...s/wallet_view/sub_widgets/wallet_summary_info.dart 0.00% 39 Missing ⚠️
.../appearance_settings/appearance_settings_view.dart 0.00% 38 Missing ⚠️
...s/token_view/sub_widgets/my_token_select_item.dart 0.00% 37 Missing ⚠️
lib/pages/exchange_view/send_from_view.dart 0.00% 35 Missing ⚠️
...preferences_views/wallet_syncing_options_view.dart 0.00% 31 Missing ⚠️
.../token_view/sub_widgets/sol_token_select_item.dart 0.00% 28 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1379      +/-   ##
===========================================
+ Coverage    13.92%   14.04%   +0.11%     
===========================================
  Files         1139     1140       +1     
  Lines       114707   115020     +313     
===========================================
+ Hits         15976    16156     +180     
- Misses       98731    98864     +133     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sneurlax

Copy link
Copy Markdown
Member Author

Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it

@sneurlax
sneurlax marked this pull request as draft August 20, 2026 18:57
@sneurlax
sneurlax force-pushed the feat/168-hide-balances branch from 5b33ccd to 0672cf8 Compare August 25, 2026 00:03
Adds the persisted `hideBalances` preference with mobile and desktop
appearance toggles, plus a `HideableBalance` wrapper that replaces a
balance with a labelled reveal control until it is tapped.
Wraps the wallet and token summaries, favourite cards, wallet list rows,
the balance toggle sheet, the token list and manage favourites, so the
preference holds on every screen reachable from a masked one.
Extends hide balances to the send views (coin, token, Solana token,
FROST, desktop send), the send balance selection sheet, the paynym send
dialog and the exchange, CakePay and ShopInBit send-from pickers. The
Firo balance choice in exchange step 4 drops the amounts from its button
labels while balances are hidden.
@sneurlax
sneurlax force-pushed the feat/168-hide-balances branch from 0672cf8 to 7ace653 Compare October 13, 2026 16:24
Preserve current staging fixes and validate the feature regression suites.

Merged staging while preserving newer locale/OpenAlias/send fixes and all masking integrations. No additional functional defect found in scoped review.
@sneurlax

Copy link
Copy Markdown
Member Author

Refreshed against staging d29d84c66049 with a merge that preserves branch history.

Merged staging while preserving newer locale/OpenAlias/send fixes and all masking integrations. No additional functional defect found in scoped review.

Validation: 7 focused tests passed; scoped Dart analysis reports no errors (13 existing warnings retained). git diff --check passes. Pushed the same commit 2755275445dd to cypherstack and github-cs.

Full app builds and device/platform end-to-end behavior were not exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Privacy] A "show/hide" balances feature for added Privacy [enhancement]

1 participant