Skip to content

feat: coin control row tap-to-toggle and per-address options menu - #1378

Draft
sneurlax wants to merge 3 commits into
stagingfrom
feat/406-coin-control-improvements
Draft

sneurlax wants to merge 3 commits into
stagingfrom
feat/406-coin-control-improvements

Conversation

@sneurlax

Copy link
Copy Markdown
Member

Tapping an address/output row now toggles its selection instead of opening the details view. A vertical ellipsis options button is added to the right of each row to reach the address options. Keeps the filtering, WillPopScope migration, and the UTXOConfirmedStatus deduplication from the prior work.

closes #406

@codecov

codecov Bot commented May 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.71875% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.93%. Comparing base (9ce80be) to head (e13d063).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../pages_desktop_specific/coin_control/utxo_row.dart 0.00% 43 Missing ⚠️
lib/pages/coin_control/utxo_card.dart 0.00% 40 Missing ⚠️
lib/pages/coin_control/coin_control_view.dart 0.00% 30 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1378   +/-   ##
========================================
  Coverage    13.92%   13.93%           
========================================
  Files         1139     1141    +2     
  Lines       114707   114739   +32     
========================================
+ Hits         15976    15991   +15     
- Misses       98731    98748   +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sneurlax

Copy link
Copy Markdown
Member Author

Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it

@sneurlax
sneurlax marked this pull request as draft August 20, 2026 18:57
@sneurlax
sneurlax force-pushed the feat/406-coin-control-improvements branch from c21e68e to 56f1a67 Compare August 25, 2026 00:16
utxo_card.dart and utxo_row.dart predate the current formatter, so any
change to them fails the repository's CI format gate. Reformat them on
their own so the change that follows reads as a behaviour diff.
Coin control rows behaved like "open details" buttons: tapping anywhere on
a card navigated away, and selection was only reachable through the small
status circle. Tapping a row now toggles its selection on both mobile and
desktop, and a trailing options button takes over navigation to the output
details.

SelectableUtxoSurface is the shared tap target; coin_control_rules.dart
holds the filter and selection predicates the mobile view uses across its
flat, search and grouped-by-address lists. The grouped query now honours
the Available/Frozen filter instead of always querying every output, so a
frozen output selected in grouped mode can be unfrozen from there.
@sneurlax
sneurlax force-pushed the feat/406-coin-control-improvements branch from 56f1a67 to 70979ff Compare October 13, 2026 16:24
Preserve current staging fixes and validate the feature regression suites.

Merged staging; retained row selection, independent options actions and grouped output filtering. No additional functional defect found in scoped review.
@sneurlax

Copy link
Copy Markdown
Member Author

Refreshed against staging d29d84c66049 with a merge that preserves branch history.

Merged staging; retained row selection, independent options actions and grouped output filtering. No additional functional defect found in scoped review.

Validation: 5 focused tests passed; scoped Dart analysis reports no errors. git diff --check passes. Pushed the same commit e13d063cb923 to cypherstack and github-cs.

Full app builds and device/platform end-to-end behavior were not exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coin control menu address improvements

1 participant