Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1375 +/- ##
===========================================
+ Coverage 13.92% 14.16% +0.23%
===========================================
Files 1139 1140 +1
Lines 114707 114745 +38
===========================================
+ Hits 15976 16256 +280
+ Misses 98731 98489 -242 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
WillPopScope is deprecated and cannot take part in Android predictive back. Static vetoes become canPop, callbacks that navigate on their own move to onPopInvokedWithResult, and the sheets that pop a value declare the result type of the route they close.
ab8a128 to
e416103
Compare
PopScope decides canPop synchronously, so the eight screens that awaited a decision in onWillPop get a wrapper that runs the callback from onPopInvokedWithResult, coalesces repeated presses, and reproduces Route.popDisposition: an approved back on the first route is handed to the platform rather than emptying the navigator.
851c0fe to
be5f6f3
Compare
WillPopScope is deprecated and cannot take part in Android predictive back. Static vetoes become canPop, callbacks that navigate on their own move to onPopInvokedWithResult, and the sheets that pop a value declare the result type of the route they close.
PopScope decides canPop synchronously, so the eight screens that awaited a decision in onWillPop get a wrapper that runs the callback from onPopInvokedWithResult, coalesces repeated presses, and reproduces Route.popDisposition: an approved back on the first route is handed to the platform rather than emptying the navigator.
|
Merged staging Validation: 47 navigation/widget tests pass, including the completed FROST route regression. Changed-file formatting and whitespace checks pass; analysis has no errors, with existing warnings/informational lints remaining. Physical-device back gestures were not exercised. |
Migrate the deprecated WillPopScope widget to PopScope across the app. Simple barrier dialogs become canPop: false/true. Cases that ran side effects or conditionally gated the pop move that work into onPopInvokedWithResult.