Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1374 +/- ##
=========================================
Coverage 13.92% 13.92%
=========================================
Files 1139 1140 +1
Lines 114707 114860 +153
=========================================
+ Hits 15976 15999 +23
- Misses 98731 98861 +130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
The dialog popped itself on Cancel, but twelve of its thirteen call sites already popped in their own onCancel handler, so on mobile Cancel tore down the dialog and the page behind it. Dismissal now belongs to the caller, and the exchange step 4 send flow gains the pop it had been relying on the dialog for.
Adds a "Coin control" row to the mobile exchange step 4 send button and to each wallet card in the send-from view, backed by a shared module: a visibility predicate, an amount-plus-fee funding estimate computed at the same rate the send will use, and a validator that re-reads every stored output from the database before opening the picker and again before sending. Outputs that went missing, changed wallet, were frozen, spent or lost their confirmations clear the selection; a merely underfunded one is kept so the user can add more. Firo is excluded.
4bf149f to
43528a2
Compare
Adds a "Coin control" row to the mobile exchange step 4 send button and to each wallet card in the send-from view, backed by a shared module: a visibility predicate, an amount-plus-fee funding estimate computed at the same rate the send will use, and a validator that re-reads every stored output from the database before opening the picker and again before sending. Outputs that went missing, changed wallet, were frozen, spent or lost their confirmations clear the selection; a merely underfunded one is kept so the user can add more. Firo is excluded.
The send itself now uses model.payInDecimal, so the coin control estimate has to as well or the selection can be sized for the wrong amount. Hide the row when the pay-in amount is unparsable.
|
Refreshed against staging Preserved staging cancellation fixes dd0d2d5 and 6a58f42 and cypherstack-only Step4 pay-in amount sizing; retained coin-control UI/selected-input wiring. Resolved duplicate cancellation state from overlapping edits. Validation: 19 focused tests passed; scoped Dart analysis reports no errors (4 existing warnings retained). Full app builds and device/platform end-to-end behavior were not exercised. |
closes #404