Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1372 +/- ##
===========================================
+ Coverage 13.92% 13.98% +0.05%
===========================================
Files 1139 1141 +2
Lines 114707 114818 +111
===========================================
+ Hits 15976 16059 +83
- Misses 98731 98759 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
Formatter-only change so later edits to this file pass the CI format gate.
Add an opt-in toggle, with an optional contact name, to the confirm transaction screen on mobile and desktop. When it is on, the recipient is written to the address book once the send goes through. Only sends with a single distinct non change recipient qualify. Trade, PayNym, PayNym notification, fee bump and Salvium stake sends are excluded because their destination is single use or the wallet's own address. Saving runs after the transaction is on its way and never surfaces its own failure as a send failure; an address already in the book is left alone. Closes #1263
sneurlax
force-pushed
the
feat/1263-save-recipient
branch
from
August 25, 2026 00:03
ae319f6 to
fb2add3
Compare
Formatter-only change so later edits to this file pass the CI format gate.
Add an opt-in toggle, with an optional contact name, to the confirm transaction screen on mobile and desktop. When it is on, the recipient is written to the address book once the send goes through. Only sends with a single distinct non change recipient qualify. Trade, PayNym, PayNym notification, fee bump and Salvium stake sends are excluded because their destination is single use or the wallet's own address. Saving runs after the transaction is on its way and never surfaces its own failure as a send failure; an address already in the book is left alone. Closes #1263
Preserve current staging fixes and validate the feature regression suites. Preserved newer multi-recipient/OpenAlias confirmation UI and transaction-preparation cancellation on dispose alongside opt-in recipient saving.
Preserve current staging fixes and validate the feature regression suites. Preserved newer multi-recipient/OpenAlias confirmation UI and transaction-preparation cancellation on dispose alongside the newer cypherstack-only default-on recipient saving with an opt-out.
Member
Author
|
Refreshed against staging Preserved newer multi-recipient/OpenAlias confirmation UI and transaction-preparation cancellation on dispose alongside the newer cypherstack-only default-on recipient saving with an opt-out. Validation: 16 focused tests passed; scoped Dart analysis reports no errors (1 existing warnings retained). Full app builds and device/platform end-to-end behavior were not exercised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1263