Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1365 +/- ##
========================================
Coverage 13.92% 13.93%
========================================
Files 1139 1140 +1
Lines 114707 114714 +7
========================================
+ Hits 15976 15984 +8
+ Misses 98731 98730 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
Replaces the separate sats/vByte row on the send confirmation screen with a wrapping amount + rate line that survives long amounts at large text scales. The rate is omitted when the virtual size is unknown or non positive, and uses the same locale decimal separator as the amount it sits beside. closes #413
sneurlax
force-pushed
the
feat/413-fee-rate-display
branch
from
August 24, 2026 21:31
85fe228 to
fbb054f
Compare
Replaces the separate sats/vByte row on the send confirmation screen with a wrapping amount + rate line that survives long amounts at large text scales. The rate is omitted when the virtual size is unknown or non positive, and uses the same locale decimal separator as the amount it sits beside. closes #413
Use FeeAmountWithRate in the namecoin and spark name confirm views in place of the separate integer sats/vByte rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #413
Refresh review (2026-11-10)
Partial supersession note: staging already contains the precise BigInt fee-rate formatter and invalid-size handling. This PR refresh wires the exact raw BigInt fee into the inline amount/rate row, adds locale-aware formatting on send, Namecoin, and Spark confirmation screens, and avoids integer truncation in the added name flows.
Checks: fee formatting/widget tests (6 passed); targeted analysis has no warnings or errors (informational style notices remain).