Repository navigation
Conversation
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
previously if it had a newline at the beginning it would choke
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
|
Conflicts in minor and resolvable ways with #1278 ... converting to a draft for now but this can be merged first |
|
will this allow you to import a monero account from the keys? |
Yes and no: yes it will allow importing via keys (in the form of a URI, anyways), but no it does not allow 12 word BIP39 seeds to be imported, which is separate functionality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1261 +/- ##
===========================================
+ Coverage 4.79% 6.03% +1.23%
===========================================
Files 1109 1113 +4
Lines 111003 111487 +484
===========================================
+ Hits 5325 6727 +1402
+ Misses 105678 104760 -918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Serializes open, node updates, native replacement and shutdown on a single mutex, and rejects queued work once shutdown has begun. The Tor transition gate parks a node update while Tor is bootstrapping and abandons it as soon as the operation is superseded.
Every LibMonero/Wownero/Salvium instance subscribed to the Tor status and preference events from its constructor, so toggling Tor ran updateNode() on the dozens of wallets Wallets.load() constructs but never opens. With a Tor-only or clearnet-only node the TOR/clearnet mismatch escaped the async listener as an unhandled exception. Listeners are now attached in open() and detached on exit() or a failed open, and the native lifecycle runs through CryptonoteWalletLifecycle so concurrent open/exit calls cannot load or tear down the native wallet twice. Because an exited wallet no longer follows node or Tor changes, open() re-runs the node update whenever the native daemon session was torn down; otherwise a reopened wallet resumes syncing over its stale clearnet session. Also corrects the inverted null guard in recoverViewOnly().
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
previously if it had a newline at the beginning it would choke
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
…20261110/pr-1261 # Conflicts: # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/wallet_keys_desktop_popup.dart # lib/services/wallets.dart # lib/utilities/address_utils.dart # test/address_utils_test.dart
…20261110/pr-1261 # Conflicts: # lib/pages/add_wallet_views/restore_wallet_view/restore_options_view/restore_options_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_backup_views/wallet_backup_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/delete_wallet_recovery_phrase_view.dart # lib/pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/delete_wallet_warning_view.dart # lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart # lib/utilities/address_utils.dart # lib/wallets/wallet/impl/monero_wallet.dart # lib/wallets/wallet/intermediate/lib_monero_wallet.dart # lib/wl_gen/interfaces/cs_monero_interface.dart # test/address_utils_test.dart
|
Merged staging at Validation: 74 URI, recovery-material, backup and secure-storage tests passed. Targeted analysis reported no errors and one test inference warning, plus informational lints. A real Monero node and native key restore were not exercised. |
supports seed, view_key only, and spend_key and view_key.