Skip to content

pstack: record outside-diff CSS-string DTCG skip #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbarstow-tw wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

pstack: record outside-diff CSS-string DTCG skip #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pstack/skills/poteto-mode/references/bugbot-triage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,11 @@ Append new candidate learnings here during or after babysitting when they look t
exists for a missing dependency rather than a failed operation.
- Source: one CLI-rename PR whose fallback existed for a missing binary rather
than a failed command.

### Outside-diff token-format complaints against catalog CSS strings

- Confidence: candidate
- Skip when: A review-automation comment asks to convert dimension or shadow tokens from CSS strings (`"0.25rem"`, `"2px 2px 4px rgba(...)"`) to structured DTCG objects, the cited tokens are outside the PR hunk or byte-identical on the base branch, and sibling tokens in the same catalog already use CSS strings for those types.
- Do not skip when: This PR added a token in a shape no sibling uses, token validation or generation fails on the tip, or the pipeline for this type cannot emit a CSS string.
- Example signal: "Use structured DTCG values" or "tooltip-radius and tooltip-shadow use CSS strings instead of the required DTCG dimension and shadow objects", posted outside the diff after a merge that only inserted neighboring tokens.
- Source: one design-token theme-bridge PR. CodeRabbit flagged landed tooltip radius and shadow CSS strings that already existed on the base branch in the same shape as the rest of the catalog.