Repository navigation
Read the full mean motion field from TLE line 2 - #428
Merged
Merged
Conversation
Convert_Satellite_Data() copied ten characters of the mean motion, which occupies columns 53-63 of line 2 and is eleven characters wide, so the eighth decimal never reached SGP4. Copy eleven characters and terminate the buffer at index eleven; buff is fifteen bytes, so there is room. test-001 now fails if the mean motion of its element set is not read as printed. Fixes csete#426
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426.
The mean motion field is eleven characters wide, but
Convert_Satellite_Data()copied ten, so the last decimal was dropped. This copies eleven and moves the terminator to match.buffis fifteen bytes, so there's room.test-001now fails if it doesn't read16.05824518from its own TLE. With the fix it builds and passes. Its positions move a little against the expected values: up to about 3 m at 1440 minutes, some closer and some further, all still under 10 m.The 604 CelesTrak sets from the issue all read back exactly now. I built
test-001on its own against GLib, not the whole app.