Repository navigation
Conversation
Also added "make distcheck" in GitHub CI workflow
| src/gtk-sat-module-tmg.c | ||
| src/gtk-sat-popup-common.c | ||
| src/gtk-sat-selector.c | ||
| src/gtk-sat-tree.c |
There was a problem hiding this comment.
This change causes the build to fail.
There was a problem hiding this comment.
Actually the files gtk-sat-tree.c and gtk-sat-tree.h are not compiled in according to src/Makefile.am.
The PR didn't go that far, but shouldn't they be removed from the repo altogether ?
That would solve the build error.
Let me know and I commit the removal.
There was a problem hiding this comment.
Ah, okay, got it.
Please do commit the removal, then I can merge it.
| gpredict_satdir = $(pkgdatadir)/data/satdata | ||
|
|
||
| gpredict_sat_DATA = satellites.dat *.cat | ||
| gpredict_sat_DATA = satellites.dat $(top_srcdir)/data/satdata/*.cat |
There was a problem hiding this comment.
Not sure why this change is necessary?
There was a problem hiding this comment.
Without this change, make invoked with VPATH tries to find the *.cat files from the local build directory, where they are not. In VPATH build, the source dir and build dir are different.
If you don't like the form, here is another way to write it :
gpredict_sat_DATA = satellites.dat $(wildcard *.cat)
There was a problem hiding this comment.
Thanks for the info. It is fine with the long form.
2 participants
Fix make distcheck and also added "make distcheck" in GitHub CI workflow