Skip to content

Finish Gtk+ 3 migration #80

Closed
Closed
Finish Gtk+ 3 migration#80
Assignees
csete
Labels
bug
Milestone
v2.2

Description

@csete
csete
opened on Dec 2, 2017

Replace all deprecated Gtk+ function calls.

  • gtk-freq-knob
  • gtk-rot-knob
  • gtk-rig-ctrl
  • gtk-rot-ctrl
  • gtk-sat-module
  • gtk-sat-module-popup
  • gtk-sat-module-tmg
  • gtk-sat-popup-common
  • gtk-sat-selector
  • gtk-single-sat
  • loc-tree
  • map-selector
  • menubar
  • pass-popup-menu
  • qth-editor
  • sat-info
  • sat-log-browser
  • sat-pref
  • sat-pref-formats
  • sat-pref-qth
  • sat-pref-qth-editor
  • sat-pref-tle
  • sat-pref-debug
  • sat-pref-layout
  • sat-pref-refresh
  • sat-pref-map-view
  • sat-pref-list-view
  • sat-pref-polar-view
  • sat-pref-single-sat
  • sat-pref-rig
  • sat-pref-rig-editor
  • sat-pref-rot
  • sat-pref-rot-editor
  • sat-pref-conditions
  • sat-pref-multi-pass
  • sat-pref-single-pass
  • sat-pref-sky-at-glance

Activity

  1. csete
    added
    bug
    on Dec 2, 2017
  2. csete
    added this to the milestone on Dec 2, 2017

  3. gvanem commented on Dec 9, 2017

    @gvanem
    gvanem
    on Dec 9, 2017
    Contributor

    In that regard, these should be applied:

    --- a/gtk-sat-module-popup.c 2017-12-07 22:12:03
+++ b/gtk-sat-module-popup.c 2017-12-08 10:06:46
@@ -1261,7 +1271,7 @@
 #ifdef G_OS_WIN32
     /* Workaround for GTK+ bug # 169811 - "configure_event" is fired
        when the window is being maximized */
-    if (gdk_window_get_state(widget->window) & GDK_WINDOW_STATE_MAXIMIZED)
+    if (gdk_window_get_state(gtk_widget_get_window(widget)) & GDK_WINDOW_STATE_MAXIMIZED)
     {
         return FALSE;
     }

    And:

    --- a/main.c 2017-12-07 22:03:48
+++ b/main.c 2017-12-08 10:08:02
@@ -403,7 +403,7 @@
 #ifdef G_OS_WIN32
     /* Workaround for GTK+ bug # 169811 - "configure_event" is fired
        when the window is being maximized */
-    if (gdk_window_get_state(widget->window) & GDK_WINDOW_STATE_MAXIMIZED)
+    if (gdk_window_get_state(gtk_widget_get_window(widget)) & GDK_WINDOW_STATE_MAXIMIZED)
     {
         return FALSE;
     }

    PS. Very good that development have moved away from the awful SF. I've build GPredict using MSVC.-2017 So I have more patches. Would you accept those?

  4. csete commented on Dec 9, 2017

    @csete
    csete
    on Dec 9, 2017
    OwnerAuthor

    Thanks for the patch @gvanem - I have applied them. I'd be happy to accept patches that improve windows support, as long as they don't break linux support ;)

  5. gvanem commented on Dec 9, 2017

    @gvanem
    gvanem
    on Dec 9, 2017
    Contributor

    Okay, my main objection is this gnu-ism: case '0' ... '9': is 8 places. Can this be moved to gpredict-utils.c at-least (and maybe with a !defined __GNUC__ check)?

  6. csete commented on Dec 9, 2017

    @csete
    csete
    on Dec 9, 2017
    OwnerAuthor

    You will have to be more specific. Most of the code was written 10 years ago and I'm old enough to barely remember what I had for breakfast this morning ;-)

    Also, please open a new issue for windows related fixes because this issue is for Gtk+ 3 migration and will be closed once Gtk+ 3 related compiler warnings have been fixed.

  7. csete
    modified the milestones: , v2.2 on Dec 14, 2017
  8. csete
    added 7 commits that reference this issue on Dec 15, 2017

    Migrate gtk-sat-module to Gtk+ 3

    cca91b4

    Migrate map-selector to Gtk+ 3

    bae640e

    Migrate loc-tree to Gtk+ 3

    28fc178

    Migrate sat-pref to Gtk+ 3

    d2edcff

    Migrate sat-pref-formats to Gtk+ 3

    c508c51

    Migrate sat-pref-qth to Gtk+ 3

    d4eb087

    Migrate sat-module-popup to Gtk+ 3

    89dcfd2

  9. 23 remaining items

  10. csete
    added 2 commits that reference this issue on Dec 26, 2017

    Add more functions to convert between GdkRGBA and config int

    82ef195

    Migrate sat-pref-sky-at-glance to Gtk+ 3

    ab2568e
  11. csete
    self-assigned this
    on Dec 27, 2017
  12. csete
    added 7 commits that reference this issue on Dec 27, 2017

    Migrate sat-pref-sat-map to Gtk+ 3

    974cade

    Migrate gtk-single-sat to Gtk+ 3

    6812e10

    Migrate gtk-freq-knob to Gtk+ 3

    cb943f0

    Migrate gtk-freq-knob to Gtk+ 3

    01c36b3

    Migrate gtk-rot-ctrl to Gtk+ 3

    3e51f31

    Migrate gtk-rig-ctrl to Gtk+ 3

    5b2785d

    Rewrite menubar code in Gtk+ 3

    7130cbb

  13. csete commented on Dec 28, 2017

    @csete
    csete
    on Dec 28, 2017
    OwnerAuthor

    DONE!

  14. csete
    closed this as completedon Dec 28, 2017

  15. kukabu commented on Dec 29, 2017

    @kukabu
    kukabu
    on Dec 29, 2017
    Contributor

    Hello

    I see the warnings yet:

    warning: ‘gtk_menu_popup’ is deprecated: Use '(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' instead [-Wdeprecated-declarations]
warning: ‘gdk_screen_width’ is deprecated [-Wdeprecated-declarations]
warning: ‘gdk_screen_height’ is deprecated [-Wdeprecated-declarations]

  16. csete commented on Dec 29, 2017

    @csete
    csete
    on Dec 29, 2017
    OwnerAuthor

    Yes, I suppose they keep deprecating things in newer versions of Gtk+ but I can not see them on my development machine. I don't expect this to be a problem for a while.

  17. kukabu commented on Dec 29, 2017

    @kukabu
    kukabu
    on Dec 29, 2017
    Contributor

    Yes, these functions has been deprecated since 3.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions