React Native .47 SplashScreenReactPackage.java #82

Activity

1. PizzaLiu commented on Aug 17, 2017

   

   PizzaLiu

   on Aug 17, 2017

   More actions

   @vivekebics

   delete this code in SplashScreenReactPackage.java

       @Override
       public List<Class<? extends JavaScriptModule>> createJSModules() {
           return Collections.emptyList();
       }

   👍React with 👍6Reacted by Rajan Maharjan, Saurabh, Nicolas Cognaux, zhangweihu, Dan Wilt and nj-io

   🎉React with 🎉1Reacted by Dan Wilt
2. devLaaziz commented on Aug 17, 2017

   

   devLaaziz

   on Aug 17, 2017

   More actions

   +1
3. Gp2mv3 commented on Aug 21, 2017

   

   Gp2mv3

   on Aug 21, 2017

   Last edited by Gp2mv3

   More actions

   Is the Splashscreen hiding for you on Android ? I've upgraded to 0.47 and now the splashScreen never hides... (see #71)

   👍React with 👍1Reacted by JerryShen
4. dwilt commented on Sep 15, 2017

   

   dwilt

   on Sep 15, 2017

   More actions

   @PizzaLiu your fix worked that's on, thanks. When can we expect to see this fixed and released? I am editing the files in node_modules and that's not a sustainable thing
5. dwilt commented on Sep 15, 2017

   

   dwilt

   on Sep 15, 2017

   More actions

   @crazycodeboy any update on this?
6. PizzaLiu commented on Sep 16, 2017

   

   PizzaLiu

   on Sep 16, 2017

   More actions

   Hi @dwilt , you can just run npm install react-native-splash-screen@latest --save in the root of your project.

   Or modify "react-native-splash-screen": "^3.0.1" in you package.json then npm install
7. dwilt commented on Sep 17, 2017

   

   dwilt

   on Sep 17, 2017

   More actions

   @PizzaLiu that's the version I currently have that has the problem
8. dwilt commented on Sep 17, 2017

   

   dwilt

   on Sep 17, 2017

   More actions

   It's still in master of 3.0.1
9. PizzaLiu commented on Sep 18, 2017

   

   PizzaLiu

   on Sep 18, 2017

   More actions

   @dwilt no, it is this line , it was fixed.
10. dwilt commented on Sep 18, 2017

    

    dwilt

    on Sep 18, 2017

    More actions

    @PizzaLiu got it, thanks! I was mixing this error up with react-native-push-notification