Skip to content

Compiling Error When running react-native run-android #77

Open
Open
Compiling Error When running react-native run-android#77

Description

@johndo31
johndo31
opened on Aug 5, 2017

Hello,

since upgrading react-native I get the following error:

node_modules\react-native-splash-screen\android\src\main\java\com\cboy\rn\splash
screen\SplashScreenReactPackage.java:22: error: method does not override or implement a method from a supertype
    @Override

Does anyone have a suggestion why this occurs?

Thanks
John

Activity

  1. johndo31 commented on Aug 5, 2017

    @johndo31
    johndo31
    on Aug 5, 2017
    Author

    Found the error with react-native 0.47

    public class SplashScreenReactPackage implements ReactPackage {

    //@Override
    //public List<Class<? extends JavaScriptModule>> createJSModules() {
    //    return Collections.emptyList();
    //}

    Solved the problem for me.

    Is it possible to remove the commented lines in the next release please?

    Cheers
    John

  2. radko93 commented on Aug 10, 2017

    @radko93
    radko93
    on Aug 10, 2017
    Contributor

    There is PR for that #74

  3. NachtRitter commented on Aug 10, 2017

    @NachtRitter
    NachtRitter
    on Aug 10, 2017

    @crazycodeboy can you please merge PR and make release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions