Skip to content

Dedup the license-notice install block and the expect_license_notice test helper #9

Open

Description

@crazyracer98

Context

Every download feature that ships an upstream license installs it to /usr/local/share/doc/<tool>/. That install block is copied into 4 install.sh files, and the expect_license_notice test helper is copied into 4 *-checks.sh files. These copies came out of the DF13 review (findings 7 and 8) and can drift apart.

Items

  • Move the license-notice install block into common/install-lib.sh as a library function, as part of the post-1.0.0 install-lib batch, then re-vendor the library into each feature.
  • Give expect_license_notice a single source: a shared test helper copied into each test directory with a drift guard, like scripts/check-install-lib-drift.sh does for install-lib.

Pointers

  • Install blocks: src/cli-keycloak/install.sh, src/cli-rustfs/install.sh, src/cli-s5cmd/install.sh, src/cli-valkey/install.sh
  • Test helper: test/cli-keycloak/keycloak-checks.sh, test/cli-rustfs/rustfs-checks.sh, test/cli-s5cmd/s5cmd-checks.sh, test/cli-valkey/valkey-checks.sh
  • Drift hook precedent: scripts/check-install-lib-drift.sh
  • Related: the install-lib efficiency batch issue

From the devcontainer-features plan close-out (2026-10-29).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions