You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should release-features.sh publish refuse to publish from a non-main ref? #22
Open question for the maintainer. scripts/release-features.sh publish pushes the features to GHCR on any full release, whichever ref release.yml was dispatched from. So a full release dispatched from a feature branch would publish unreviewed features under real version tags. This came up as finding 2 of the DF14b review. The other craftainer repos don't guard against this either, so a fix might belong in template-base's release.yml rather than here.
Items
Decide whether a full publish should refuse to run from a ref other than main.
If yes, decide where the guard goes: scripts/release-features.sh (this repo only) or base's release.yml (the whole family, via template-sync).
Implement it and document it in the release docs.
Pointers
scripts/release-features.sh (publish)
.github/workflows/release.yml (synced from template-base, kept byte-identical)
Activity