Skip to content

Should release-features.sh publish refuse to publish from a non-main ref? #22

Open

Description

@crazyracer98

Context

Open question for the maintainer. scripts/release-features.sh publish pushes the features to GHCR on any full release, whichever ref release.yml was dispatched from. So a full release dispatched from a feature branch would publish unreviewed features under real version tags. This came up as finding 2 of the DF14b review. The other craftainer repos don't guard against this either, so a fix might belong in template-base's release.yml rather than here.

Items

  • Decide whether a full publish should refuse to run from a ref other than main.
  • If yes, decide where the guard goes: scripts/release-features.sh (this repo only) or base's release.yml (the whole family, via template-sync).
  • Implement it and document it in the release docs.

Pointers

  • scripts/release-features.sh (publish)
  • .github/workflows/release.yml (synced from template-base, kept byte-identical)
  • docs/adrs/0004-collection-github-releases.md, docs/adrs/0005-publish-to-ghcr-with-github-token.md

From the devcontainer-features plan close-out (2026-10-29).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions