Skip to content

install-lib: efficiency and refactoring batch (post-1.0.0) #10

Open

Description

@crazyracer98

Context

common/install-lib.sh is the shared library every feature vendors as src/<id>/install-lib.sh. The DF1c review (items 3 and 5–9) and the DF5 review left efficiency and refactoring items that aren't bugs. Every change means re-vendoring the library into all features and bumping each one, so they should land together in one batch.

Items

  • Give a clearer error when the exact-dependency lookup in il_apt_install_pinned fails.
  • Add other-arch test cases for the env and pins-file channels.
  • Run one apt-get update instead of several on bare images.
  • Parse the pins file once rather than on each lookup.
  • Share one channel loop (option, image env, pins file) between il_resolve_version and il_resolve_pin.
  • Add a public il_pins_get, and switch cli-keycloak from the private _il_pins_get to it.
  • Consider a softer il_user_state_dir: skip with a warning instead of failing when the remote user's home doesn't exist yet (e.g. common-utils creates the user but installs after this feature). Today that fails the build, and NOTES.md tells consumers to use overrideFeatureInstallOrder (DF5 review).
  • Fold in the license-notice install block (see the license-notice dedup issue).

Pointers

  • common/install-lib.sh, common/README.md
  • scripts/check-install-lib-drift.sh (keeps the vendored copies in sync)
  • src/cli-keycloak/install.sh (lines that call _il_pins_get)
  • ADR 0002 and ADR 0003 under docs/adrs/

From the devcontainer-features plan close-out (2026-10-29).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions