improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 - #4611

Merged

danmar merged 17 commits into

cppcheck-opensource:mainfrom

firewave:mathlib-sto

Dec 7, 2022

Commits on Dec 5, 2022

testmathlib.cpp: split `toULongNumber` into separate test case
firewave
committed
74d554e
testmathlib.cpp: aligned tests in `toLongNumber` and `toULongNumber`
firewave
committed
d71e86d
mathlib.cpp: fixed handling of negative binary numbers in `toULongNumber()`
firewave
committed
32bcbc8
mathlib.cpp: added handling of `std::invalid_argument` to `std::stoull()` calls
firewave
committed
1eff4f1
mathlib.cpp: added missing handling of char literals to `toULongNumber()`
firewave
committed
5b3ff5e
testmathlib.cpp: check exception messages
firewave
committed
1114b90
testmathlib.cpp: added tests which produce `std::invalid_argument` exception
firewave
committed
2dd2dfa
MathLib: removed pointless info from `to{U}LongNumber()` exception messages
firewave
committed
e7edc7b
fixed #10695 - make sure the whole input is being consumed in `MathLib::to{U}LongNumber()`
firewave
committed
5553908
mathlib.cpp: use `toDoubleNumber()` in `toULongNumber()` as well
firewave
committed
f40781b
MathLib: improved handling of invalid input in `toDoubleNumber()` / increased test coverage
firewave
committed
708162a
ubsan.yml: added `report_error_type=1` to `UBSAN_OPTIONS`
firewave
committed
42bc53b
mathlib.cpp: fixed UBSAN warning about negative double being out-of-range in `toULongNumber()`
firewave
committed
80522d9
MathLib: fixed incorrect `toString()` result if it contains an exponent
firewave
committed
1c36cde
mathlib.cpp: avoid unnecessary copies in `toString()`
firewave
committed
91b1233
added CMake option `USE_LIBCXX` to use `libc++` instead of `libstdc++` and also set `LIBCXX_ENABLE_DEBUG_MODE` in `Debug` build
firewave
committed
0927ad4
testmathlib.cpp: adjustments for `libc++`
firewave
committed
7912e26

Navigation Menu

Uh oh!

improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 - #4611

improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695#4611
danmar merged 17 commits into
cppcheck-opensource:mainfrom
firewave:mathlib-sto

Commits on Dec 5, 2022

testmathlib.cpp: split `toULongNumber` into separate test case

testmathlib.cpp: aligned tests in `toLongNumber` and `toULongNumber`

mathlib.cpp: fixed handling of negative binary numbers in `toULongNumber()`

mathlib.cpp: added handling of `std::invalid_argument` to `std::stoull()` calls

mathlib.cpp: added missing handling of char literals to `toULongNumber()`

testmathlib.cpp: check exception messages

testmathlib.cpp: added tests which produce `std::invalid_argument` exception

MathLib: removed pointless info from `to{U}LongNumber()` exception messages

fixed #10695 - make sure the whole input is being consumed in `MathLib::to{U}LongNumber()`

mathlib.cpp: use `toDoubleNumber()` in `toULongNumber()` as well

MathLib: improved handling of invalid input in `toDoubleNumber()` / increased test coverage

ubsan.yml: added `report_error_type=1` to `UBSAN_OPTIONS`

mathlib.cpp: fixed UBSAN warning about negative double being out-of-range in `toULongNumber()`

MathLib: fixed incorrect `toString()` result if it contains an exponent

mathlib.cpp: avoid unnecessary copies in `toString()`

added CMake option `USE_LIBCXX` to use `libc++` instead of `libstdc++` and also set `LIBCXX_ENABLE_DEBUG_MODE` in `Debug` build

testmathlib.cpp: adjustments for `libc++`