runtime: --version answers and exits - #7
Merged
Merged
Conversation
It started a runtime, like any argument the binary does not know: docker run IMAGE vejas-runtime --version stayed up for a day. e2e/detect D3 checks it, with nothing for an older binary to reach. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3K1TGnWTvwYzt9rKuJXES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vejas-runtime --version(or-V) now printsvejas-runtime <version>and exits 0.Before this, the binary ignored arguments it did not know and started a runtime.
docker run ghcr.io/cpoder/vejas-runtime:v0.3.0 vejas-runtime --versionwas left running on a dev box for 28 hours, when it should have printed a line and exited.Other unknown arguments still start the runtime, as before, so that no existing deployment that passes one breaks.
Test:
e2e/detectD3 checks it. It runs the binary with a deadNATS_URLand an empty root, undertimeout -k, so an older binary that starts a runtime reaches nothing and is killed.✓ --version answers and exits: vejas-runtime 0.3.5.VEJAS_BIN=...):✗ --version: ... got: [vejas] supervising 0 units.🤖 Generated with Claude Code
https://claude.ai/code/session_01N3K1TGnWTvwYzt9rKuJXES