engine: Varpulis at 4e3dbb5, windows close on event time - #3
Merged
Merged
Conversation
…84, #285) A time window in a detect unit closed only when a later event reached that same window: a count per address waited for the same address's next failure, so a brute force that ended in a successful logon was never raised in a running unit. The engine now closes a window when the event time of the types feeding it passes its end, on any event of those types, upstream first. A sequence step that names a derived stream now reads what that stream outputs (over an aggregate it matched the raw events). e2e/detect gains D6: three failures from one address, a success from it, then a logon from another address after the window. On the previous runtime nothing is ever raised; on this one the next logon raises the brute force with its count. D4 now lists three units. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3K1TGnWTvwYzt9rKuJXES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A time window in a detect unit closed only when a later event reached that same window. A count per address waited for the same address's next failure. A brute force that ended in a successful logon was therefore never raised in a running unit.
varpulis simulatehid this, because it closes every window at the end of a file.What changes
4e3dbb5. It brings two fixes:.watermark()used to hold back every window.e2e/detectD6. The scenario is three failures from one address, a success from the same address, then a logon from another address after the window.VEJAS_BIN= the v0.3.1-era build), D6 fails: nothing is ever raised.n = 3.detects.mdsays when windows close. The CHANGELOG entry sits under Unreleased.Checks run locally
cargo test: 43 passed.e2e/detect/run.sh: all invariants hold, D6 included.e2e/detect-demo/run.sh: every beat holds.🤖 Generated with Claude Code
https://claude.ai/code/session_01N3K1TGnWTvwYzt9rKuJXES