fix: cap npm at 11.x so the publish job works on node 20 - #101
Merged
Merged
Conversation
azebuado
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Publish NPM Packagejob has been failing since August, so@cowprotocol/cmsis stuck at0.13.0on npm while this repo is at0.15.0.Two constraints collided:
NODE_VERSIONis pinned tolts/iron(Node 20) because Strapi 4.26.1 doesn't support Node 22.npm@latestis now npm 12, which declaresengines.node: "^22.22.2 || ^24.15.0 || >=26.0.0".So the
npm install -g npm@lateststep aborts withEBADENGINEbefore the job ever reachesyarn installorpublish-lib.sh:Capping the range at
^11resolves to 11.19.1, whoseengines.nodeis"^20.17.0 || >=22.9.0"— satisfied by the runner's v20.20.2 — while staying above the>= 11.5.1that trusted publishing needs. The step keeps doing its job; it just stops following npm across a
major that Node 20 can't run.
Unblocks cowprotocol/cowswap#7846, which needs the CMS collection types
from
0.15.0.