Skip to content

chore: put API requests into dedicated class - #76

Merged
y-lakhdar merged 2 commits into
mainfrom
LENS-976
Jun 16, 2023
Merged

y-lakhdar merged 2 commits into
mainfrom
LENS-976

Conversation

@y-lakhdar

@y-lakhdar y-lakhdar commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Simplify PlatformClient by removing code duplication 🥳

image

Prepare groundwork to handle throttling.

Create an ApiCore class to handle all API requests

p.s.

I need a PR to trigger the release GitHub action since it did not work last time. The release failed because previous versions (v.2.1.0 and v2.2.0) were not tagged. Therefore, the release action did not bump the pom.xml version to the right one.

@y-lakhdar
y-lakhdar requested review from a team, louis-bompart, mrrajamanickam-coveo and olamothe and removed request for a team June 15, 2023 14:55
@github-actions

github-actions Bot commented Jun 15, 2023

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

Comment thread src/main/java/com/coveo/pushapiclient/ApiCore.java
Comment thread src/main/java/com/coveo/pushapiclient/ApiCore.java
@y-lakhdar
y-lakhdar enabled auto-merge (squash) June 16, 2023 17:04
@y-lakhdar
y-lakhdar merged commit f555753 into main Jun 16, 2023
@y-lakhdar
y-lakhdar deleted the LENS-976 branch June 16, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants