Skip to content

ci: ensure semantic title - #41

Merged
y-lakhdar merged 3 commits into
mainfrom
LENS-906
Jun 9, 2023
Merged

y-lakhdar merged 3 commits into
mainfrom
LENS-906

Conversation

@y-lakhdar

Copy link
Copy Markdown
Contributor

Before automating releases with Conventional Commit Messages, we need to ensure PR titles are properly written.

I added a package.json to leverage @commitlint/config-conventional.

It feels weird to have a package.json in a Java project, but it is only used by the CI. It does not impact development

@y-lakhdar
y-lakhdar requested review from a team, btaillon-coveo, louis-bompart and olamothe and removed request for a team June 8, 2023 13:24
@github-actions

github-actions Bot commented Jun 8, 2023

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

.github/workflows/pr-title-semantic-lint.yml
package-lock.json
  • @commitlint/config-conventional@17.4.4
  • array-ify@1.0.0
  • compare-func@2.0.0
  • conventional-changelog-conventionalcommits@5.0.0
  • dot-prop@5.3.0
  • is-obj@2.0.0
  • lodash@4.17.21
  • q@1.5.1
package.json
  • @commitlint/config-conventional@17.4.4

@y-lakhdar
y-lakhdar enabled auto-merge (squash) June 8, 2023 13:26
Comment thread .github/workflows/pr-title-semantic-lint.yml
@y-lakhdar
y-lakhdar requested a review from hdhayneCoveo June 8, 2023 17:37
Comment thread .github/workflows/pr-title-semantic-lint.yml
@y-lakhdar
y-lakhdar merged commit d9b0b47 into main Jun 9, 2023
@y-lakhdar
y-lakhdar deleted the LENS-906 branch June 9, 2023 15:56
y-lakhdar added a commit that referenced this pull request Jun 20, 2023
* ci: ensure semantic title

* ci: remove unnecessary config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants