Conversation
y-lakhdar
requested review from
a team,
btaillon-coveo,
hdhayneCoveo,
mrrajamanickam-coveo and
olamothe
and removed request for
a team
May 25, 2023 18:32
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
Update src/main/java/com/coveo/pushapiclient/ApiUrl.java Co-authored-by: Benjamin Taillon <54454747+btaillon@users.noreply.github.com> add new getter to source classes feat: create `PushSource` and `catalogSource` classes (#30) https://coveord.atlassian.net/browse/LENS-839 update StreamService add platformClient tests add PowerMockito dependencies remove unused import remove unecessary method downgrade build to Java 11 revert codeql deletion lint lint
y-lakhdar
marked this pull request as draft
May 25, 2023 18:50
y-lakhdar
marked this pull request as ready for review
May 25, 2023 18:52
btaillon-coveo
approved these changes
May 25, 2023
jpmarceau
approved these changes
May 25, 2023
Co-authored-by: Benjamin Taillon <54454747+btaillon@users.noreply.github.com>
Co-authored-by: jpmarceau <39384459+jpmarceau@users.noreply.github.com>
Co-authored-by: jpmarceau <39384459+jpmarceau@users.noreply.github.com>
y-lakhdar
enabled auto-merge (squash)
May 31, 2023 15:56
mrrajamanickam-coveo
approved these changes
May 31, 2023
y-lakhdar
added a commit
that referenced
this pull request
Jun 20, 2023
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Implement the
StreamServiceclass, which is responsible of uploading documents into the source using the "Stream mode" (aka full source rebuild).Testing
### TL;drI also added new dependencies (org.powermock) to be able to test classes without having to do dependency injection.### Full explanation:StreamServiceclass depends on 2 other classes:DocumentUploadQueuePlatformClientIdeally, these 2 classes would have to be injected to intoStreamServiceduring its initialization to facilitate testing:However, this would lead to bad user experience as the user would have to manually instantiate both objects before using theStreamService. PowerMock allows to mock objects instantiated within theStreamServiceclass.I also had to downgrade Mockito so it can properly work with PowerMockitoEdit
Created an internal class
StreamServiceInternalto facilitate unit testing.