docs: retire scheduler.* and watch.* from the protocol vocabulary - #15
Merged
ualtinok merged 1 commit intoAug 14, 2026
Merged
Conversation
Code commit 0248b51 retired these prefixes while this document continued to advertise them. lease.* remains deliberately untouched pending a maintainer decision. The request enum lagged master by supervisor.health and supervisor.health_probe; supervisor.stderr_tail remains unmerged and excluded.
There was a problem hiding this comment.
No issues found across 1 file
You're on the cubic free plan with 14 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
ualtinok
added a commit
that referenced
this pull request
Aug 14, 2026
Follows #15 (scheduler.*/watch.* retirement). Cross-module single-writer arbitration ships at the store layer (cortexkit-lease: advisory lock + persisted epoch CAS per store), so a daemon-level lease op family would duplicate an invariant the storage substrate already enforces. Raised in the second half of #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the doc half of #13. You removed
ops::SCHEDULERandops::WATCHin0248b51;docs/subc-control-protocol.mdwas untouched, so it became the only place still advertising them.That's worth naming precisely: before the commit, code and doc agreed and both were wrong. After it, the doc is the sole surviving source of the misreading — and it's the file someone surveying the protocol reads first. Strictly worse than before, not better.
Your rationale in the source comment is the one I applied:
That contributor is me. #1 and #2 exist because I read those prefixes as a plan.
What changed
Six sites, doc-only:
:14— thin-core principle:lease/scheduler→lease:98— request enum's FUTURE comment: droppedscheduler.*andwatch.*, keptconfig.*:170— push-direction reservation: droppedwatch.*from the examples. The reservation itself survives — it's still valid, only that example was retired:173— thin-core ops table: droppedscheduler.*and thewatch.*clause:183— baseline-op example:a future scheduler.*/lease.*→a future lease.*:184— reserved prefixes list: dropped bothlease.*is deliberately untouched. It's still open:docs/subc-core-architecture.md:207couples it to the scheduler, but its stated job — stopping two modules dreaming the same project at once — is cross-module arbitration, which is supervisor-shaped rather than scheduler-shaped. If it follows scheduling toprefrontal, nothing arbitrates between modules; if it stays, it stays without the thing it was specified alongside. Your call, and removing it here would have pre-empted it.Second correction in the same file
The request enum was two supervisor ops behind: added
supervisor.healthandsupervisor.health_probe, both verified inSUBC_CONTROL_OPSon master.supervisor.stderr_tailis not added. It's from #10, unmerged — documenting an op that doesn't exist upstream would repeat the exact defect this PR fixes. It goes in with that PR or not at all.Worth flagging one thing about my own process here: I briefed this as "three ops missing" and it was two, because I counted in my own tree where
stderr_tailexists. Same error class as the reservation itself — a name present locally read as a name present generally.Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Retires
scheduler.*andwatch.*from the control protocol docs to match the code and avoid implying future features. Documentssupervisor.healthandsupervisor.health_probe;lease.*remains as a future prefix.scheduler.*/watch.*mentions indocs/subc-control-protocol.md(thin-core principle, FUTURE note, client push example now onlyroute.*/catalog.*, thin-core ops table, baseline text, reserved prefixes).supervisor.healthandsupervisor.health_probetoClientControlRequest; leftsupervisor.stderr_tailout because it’s unmerged.Written for commit ade26c9. Summary will update on new commits.