Conversation
Automated dependency upgrade by OrbisAI Security
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Thanks for the scan and the PR — the CVE is real and we want it silenced. But this mechanism doesn't remediate it: adding The fix that actually moves the transitive resolution in Bun is an "overrides": {
"adm-zip": "0.6.0"
}…followed by a lockfile regeneration, verification that the resolved copy under transformers is now 0.6.0, and a quick check that the transformers zip path still functions (0.6.0 is a minor-line jump from 0.5.x; their usage is narrow, but worth one local-embedding smoke run — Context on urgency: our earlier reachability analysis (#254) concluded this path isn't reachable with hostile input in our runtime (matches your scanner's "not confirmed reachable"), so this is hygiene rather than exposure — but hygiene we'd gladly take. If you update the PR to the overrides mechanism with the resolution verified, we'll merge it; if you'd rather not, say so and we'll fold it into our next dependency pass with credit. |
…-39244 The prior fix added adm-zip@0.6.0 as an unused root dependency, leaving the actual vulnerable copy (transitive via @huggingface/transformers -> onnxruntime-node) resolved at 0.5.17. A package.json "overrides" entry forces that transitive resolution to 0.6.0 instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Review comments addressed. Pls review. |
|
Merged — the overrides rework is exactly right. Verification on the PR tree: frozen install clean, |
Summary
Upgrade adm-zip from 0.5.17 to 0.6.0 to fix CVE-2026-39244.
Vulnerability
CVE-2026-39244bun.lock(dependency:adm-zip)Description: adm-zip: adm-zip: Denial of Service via crafted ZIP file leading to excessive memory allocation
Evidence
Scanner confirmation: trivy rule
CVE-2026-39244flagged this pattern.Threat Model Context
This is a private Node.js application (not published to npm). Vulnerabilities affect this application's own runtime only.
Changes
bun.lockpackage.jsonBehavior Preservation
The change is scoped to 2 files on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
This change addresses a pattern flagged by static analysis. The code path handles user-influenced input and the fix reduces the attack surface against both manual and automated exploitation.
Automated security fix by OrbisAI Security
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Pins
adm-zipto 0.6.0 viaoverridesto remediate CVE-2026-39244 (crafted ZIP DoS). Previouslyonnxruntime-noderesolvedadm-zip@0.5.17; now all paths resolve to 0.6.0, leaving valid archives unaffected.package.json(addsoverrides.adm-zip: 0.6.0) andbun.lock(regenerated; alladm-zipentries are 0.6.0).bun installand re-run the security scan.Written for commit 0ff16f2. Summary will update on new commits.
Greptile Summary
The PR globally overrides
adm-zipto 0.6.0 and updates the lockfile resolution to remediate CVE-2026-39244.adm-zipoverride topackage.jsonandbun.lock.adm-zip@0.5.17package withadm-zip@0.6.0.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
adm-zip@0.6.0override consistent with the generated lockfile.adm-zip@0.6.0; no vulnerable 0.5.17 resolution remains.Reviews (2): Last reviewed commit: "fix: use overrides instead of a root dep..." | Re-trigger Greptile