Skip to content

Timesheets: the last backlog items and the weekend ruling - #232

Open
corrin wants to merge 3 commits into
mainfrom
fix/one-time-entry
Open

corrin wants to merge 3 commits into
mainfrom
fix/one-time-entry

Conversation

@corrin

@corrin corrin commented Nov 4, 2026

Copy link
Copy Markdown
Owner

The week's last timesheet items after #229 and #230. Plan: docs/plans/2026-11-05-time-leftovers.md (no open issues).

  • The backlog drops three timesheet items One way to put time onto a job #230 already closed: hours past an entry's span, to_decimal's silent default, and a stale labour_subtype on a job repick.
  • The office grid's focus handoffs search the grid, not the page.
  • One is_billable read: the accounting reports read the boolean every actual time line carries (0 of 13,709 differ).
  • My time honours weekend_timesheets_enabled (owner, 2026-11-05), as the office entry page does.
  • The job picker's data stands (owner, 2026-11-05): staff see jobs, estimates and charge-out rates, never another person's pay.

Payroll/Xero items stay in the backlog (owner: timesheets only).

Tests

  • E2E: workshop-my-time-view, create-timesheet-entry, keyboard-nav and office-overtime, 19 passed.
  • vitest: 795 passed.
  • pytest: apps/accounting, 189 passed.

🤖 Generated with Claude Code

corrin and others added 3 commits November 5, 2026 06:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lable read

- SmartTimesheetTable focuses its own controls through its root, not the page.
- The accounting reports read is_billable as the boolean every actual time
  line carries (0 of 13,709 differ); the string encoding was dead.
- The backlog drops the three timesheet items #230 already closed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With weekend timesheets off, My time's day arrows step over the weekend and a
weekend today opens on Monday, as the office's entry page does. The owner
also ruled the job picker's data stands: staff see jobs, estimates and
charge-out rates, never another person's pay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ff194317-d65f-42b6-a821-ee0b23da478c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant