Mod hash func to exclude SB key - #215
Open
GybiBite wants to merge 1 commit into
Open
Conversation
Previous version didn't account for potential user-added secure boot key(s), new function strips any keys if present before calculating function. This does not affect hash calculation of other files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #214
When OpenCore.efi was signed by the user for secure boot, the MD5 hash of the file would change. This new hash function detects EFI files, checks for a signature, and strips the keys if any were appended before calculating the hash. This retains all old hash values, and shouldn't change any existing functionality. This also excludes the nested
finish(f,path)function, as thefinally:block is subjectively cleaner. Regardless of how the function exits, thefinally:block is called.