bootupctl: only print the available component when running status in container - #1069
bootupctl: only print the available component when running status in container#1069HuijingHei wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates bootupctl status to only show components with available update metadata when running inside a container. The changes in the Rust code are logical and well-implemented. However, the associated test script in tests/tests/bootupctl-status-in-bootc.sh contains a couple of issues. Specifically, the expected JSON output for the 'no components' scenario is incorrect, and the test case for this scenario lacks assertions, failing to verify the behavior. I've provided detailed comments and suggestions to address these issues in the test script.
850ed45 to
77d5e28
Compare
in container Skip the component if the update meatadata is missing
77d5e28 to
b7c1da3
Compare
|
@cgwalters could you help to review this when you have a chance? Thank you! |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Skip the component if the update meatadata is missing