Repository navigation
Let the theme style the round menu buttons - #600
Merged
corecoding merged 1 commit intoOct 11, 2026
Merged
Conversation
The three round buttons in the popup (Refresh, System Monitor, Preferences) borrowed the shell's message-list-clear-button class to obtain their circular look. That class only exists for the Clear button in the notification list and is scoped to .message-list-controls there, so under any popup theme that styles popup controls it no longer produces the intended look. Keep the generic .button class, which every GNOME button already carries and which the shell theme and popup themes hook for background and interactive states, and let vitals-button-action own only the geometry (radius, padding, min-size) plus the icon style. The hover/focus border the extension declared itself is removed: the 2020 commit that added it existed to stop size flicker, which no longer applies once the border is left to the theme.
Octopustank
force-pushed
the
fix/round-menu-button-theme-class
branch
from
October 11, 2026 02:04
9cb34eb to
b25cda7
Compare
Contributor
Author
Owner
|
I sat down to merge this branch, saw the conflict - was going to reach out but you beat me to it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599
Problem
The three round buttons at the top of the popup (Refresh, System
Monitor, Preferences) are
St.Buttons built with(
extension.js,_createRoundButton).message-list-clear-buttonisthe shell's own class for the Clear button in the notification list,
where it only carries rules under
.message-list-controls— so inVitals' popup it contributes nothing, and the circular look the borrow
was presumably after actually comes from
vitals-button-action's owngeometry. What the buttons do wear from the theme is the generic
.buttonstyling.Change
message-list-clear-button, keeping the genericbuttonclass — the hook the shell theme styles for background andinteractive states — plus
vitals-button-action.vitals-button-actionnow owns only geometry (radius, padding,min-size) and the symbolic icon style; background and hover/active
states come from the theme.
transparent default border added in 2020 to stop size flicker when
the border appeared on hover. The theme's interactive states change
background and box-shadow, not borders, so the flicker does not
return.
Buttons keep the same icons, handlers, size and circular shape under the
default theme, and now follow the same theme rules as other popup
buttons instead of borrowing a class scoped to another widget.
Behavior on my machine with blur-my-shell (using refactor/unified-blur-backend branch):
Notes
Open PR #596 also touches
stylesheet.css(.vitals-panel-label-fixed),a few lines above; the two edits do not overlap.
No schema, prefs, or locale changes; no version bump (EGO owns
submission versioning).