Repository navigation
prune network interfaces that no longer exist - #577
Merged
Merged
Conversation
This was referenced Aug 9, 2026
corecoding
added a commit
that referenced
this pull request
Sep 5, 2026
Resolve the network query conflict by keeping the interface prune from this PR and leaving public-IP polling on develop's existing path.
corecoding
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #557.
The problem
Vitals never forgets a network interface. Once one disappears from
/sys/class/net,nothing removes it from
_history,_networkSpeedsor_networkSpeedOffset.Two effects:
Device rx/txsums every entry in_networkSpeeds, so a dead interface's last speed keeps being counted.The fix
When
_queryNetworksees an interface disappear, it reports'destroy'for that sensorthrough the normal callback. The same mechanism is used by a disabled sensor to report
'disabled'.extension.jshandles it next to the existing'disabled'check and drops the menu item, the hot item and the stored history.A few notes on the choices, happy to change any of them:
hot-sensorsis left alone, so a pinned interface comesback if it reappears rather than being silently unpinned.
/sys/class/net, not on it being down. So,a down interface keeps its directory, so toggling wifi does nothing here. I avoided matching
on
veth*/br-*names since that would hide real docker bridges.