Skip to content

Sidebar toggle issues #10

Open
Open

Description

@mmacfadden

The side bar toggle will scroll off the screen. And when it does it goes OVER the title bar:

sidebar-toggle

We should have the side bar toggle be fixed in the middel (vertically) of the screen.

Activity

  1. alalonde commented on Jan 10, 2020

    @alalonde
    Contributor

    Just pushed a fix for the z-index issue.

    Also, notice in the screenshot how the header for the chat example looks different than for any other example. That was fixed in e5eda3c.

    If we want the sidebar toggle to be position: fixed, we should make the whole sidebar fixed as well.

  2. mmacfadden commented on Jan 10, 2020

    @mmacfadden
    ContributorAuthor

    @alalonde yes.. I had not pulled the latest yet.

    What would making the whole sidebar fixed mean? Would have have to have is scroll inside its container? If so, I am not sure that would be intuitive to users The main problem is that you can easily scroll the toggle off the screen and not be able to find it. It seems natural to just have it centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions