Repository navigation
CI build setup - #7
Merged
Merged
Conversation
added 10 commits
January 19, 2024 18:08
gpeacock
approved these changes
Jan 20, 2024
gpeacock
left a comment
gpeacock
left a comment
Member
There was a problem hiding this comment.
This looks great. I'd been using maturin 1.4 but 1.2 should be fine.
dkozma
marked this pull request as ready for review
January 22, 2024 15:26
added 6 commits
January 22, 2024 10:28
Removed the maturin message so that people don't blindly replace it and lose the custom changes.
BibinBaby444
pushed a commit
to BibinBaby444/c2pa-python
that referenced
this pull request
Sep 30, 2026
… from CBOR Follow-ups from the review of b13e8a3. The real-ladder test now checks the strong property from the bytes: the manifest embedded in each output, read straight from the C2PA uuid box after its merkle_offset, must equal the bytes sign_ladder returned, and the one bmff hash assertion must carry one Merkle map per rendition -- decoded from the manifest's own CBOR, so the check no longer depends on how a given Reader version renders hash assertions as JSON. Reader is kept only for the validation result, and the JSON-presentation assertions on the hash assertion are gone. cbor2 is imported inside the one helper that needs it: the seventeen stand-in tests must keep running in a lane without it, and they do -- verified with the module hidden. Against a library built from the contentauth#7+contentauth#9 stable tree with C2PA_REQUIRE_SIGN_LADDER=1: 18 passed. Against the stock library: 17 passed, the native test skipped as designed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
BibinBaby444
pushed a commit
to BibinBaby444/c2pa-python
that referenced
this pull request
Sep 30, 2026
An adversarial pass over fc26ec2 found two things. The jumd label check tested toggle bit 0x01, which is Requestable; Label Present is 0x02. c2pa-rs's reader requires both (togs & 0x03 == 0x03) and its writer always emits 3, so the test passed for the right files by accident. It now tests 0x02, with a comment saying why. The README's "inspect or discard the destinations" was the indiscriminate wording the maintainer rejected on castlabs/c2pa-rs#9, and this binding's docs must give the same guidance as the native ones: a destination that already existed is refused before anything is written and never touched; on a native failure the writer removes what is then at the output paths it reserved, by path and best effort; discard only the leftovers at the destinations you passed, never a pre-existing file such as a source or a link to one. The two new assert messages that ran past the file's line length are wrapped. Against a library built from the contentauth#7+contentauth#9 stable tree with C2PA_REQUIRE_SIGN_LADDER=1: 18 passed. Stock library with cbor2 hidden: 17 passed, 1 skipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.